From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E957CC47088 for ; Mon, 5 Dec 2022 07:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231453AbiLEHdq (ORCPT ); Mon, 5 Dec 2022 02:33:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231745AbiLEHdo (ORCPT ); Mon, 5 Dec 2022 02:33:44 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C637F13F06 for ; Sun, 4 Dec 2022 23:33:42 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id 1so3559995lfz.4 for ; Sun, 04 Dec 2022 23:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vKyvkeRamE9a3hWvsk2ihpAKYDCVRVxYyiAwylPFe8A=; b=LIKhtUFyXh0G/bghBM8oVR7yeeb5PKyfqo1/clecg5SD5xD+1TT3F0WFBAHDJDaQBH n0CK4GhDIB2CYYfcuYLAJ8nr5L5vrqYmAPQgk63FXei2LykNJkYmMMWbWjz7Q0kX7vos GERhXFSGxCv91XHcT5x5xhOKszlXTnrWDBT3kG1FgqGL3p93zbfERKbNj3zMHEoPtQ2A n91LV9CiX2paipVF1F+tKaSIkPSpSp+hMt5gCT8ZWclXhM9h+ryH4vhw5aAgJ+lWQ+1H 4Ua4DzdBMBodlmaVl7JaSHhVOR69QKFryxHPeXuBu6k3fdRVhOYcGnYtopgi3Kxbt9my Ac5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vKyvkeRamE9a3hWvsk2ihpAKYDCVRVxYyiAwylPFe8A=; b=Z7tcYCNaAYW1T/q6TW4J5kvih6URj2bild0a9uQqNMnKrzAADCe2Hti9XvDuaLrRlE GBsZ2haKRk/LRc+KuxlwoQJd0onf6zekHk3tVO0tCY9nsYbxhI9XjMZrhrVPpp0c6xrf FqoefrY4nsqmrCxX22qmVOnyO0nWb4lX7lB3h4L5T8jS1EOx6WIfZH0kft8u6h9mUT1K kBapcw/fKSedknNWBDC1540HX5Yr0alfUwXu6mvgGPDzIJ+KRuHzyoIDYEhj1ZNcRyep C3XCw3TOHlkKQ1+jqoAPgk7v1LOhVk1WrR5tk2+rU/vJ4JNh6eqVvetSWzwbKkGWb4SH UJZQ== X-Gm-Message-State: ANoB5pmTn+A3kYbxSlpATC5RIF6BRsA1Yp0LTQMTa3lEd8H7gPoOnsfp C9eSTyC/Lfq46/JyeRvh0yP+ow== X-Google-Smtp-Source: AA0mqf5ikodifhglBYX/PfKt8BsPYKz7SE+18MCVYQBQHbRQFQs3Xt9PDn1r+0Ors1BkPLl4bYLNGQ== X-Received: by 2002:ac2:46f7:0:b0:4b0:25f9:14f5 with SMTP id q23-20020ac246f7000000b004b025f914f5mr20568296lfo.506.1670225621140; Sun, 04 Dec 2022 23:33:41 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id g3-20020a056512118300b0049ad2619becsm2028155lfr.131.2022.12.04.23.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Dec 2022 23:33:40 -0800 (PST) Message-ID: <92df8e1d-eb7b-ec0b-264f-a1a090cececc@linaro.org> Date: Mon, 5 Dec 2022 08:33:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH v1 2/2] usb: host: add xhci-exynos to support Exynos SOCs Content-Language: en-US To: Jung Daehwan Cc: Mathias Nyman , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Mathias Nyman , Linus Walleij , Colin Ian King , Artur Bujdoso , Juergen Gross , Tomer Maimon , "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com References: <1669860811-171746-1-git-send-email-dh10.jung@samsung.com> <1669860811-171746-3-git-send-email-dh10.jung@samsung.com> <20221205023413.GD54922@ubuntu> From: Krzysztof Kozlowski In-Reply-To: <20221205023413.GD54922@ubuntu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 05/12/2022 03:34, Jung Daehwan wrote: >>> Am I missing something here? >> >> Because it is not a driver for Exynos... it's a driver for wakelocks for >> their specific Android use-cases which the manufacturer ships for their >> Android devices. Due to Google GKI, they try to squeeze into upstream. >> But this is huge misconception what should go to upstream and Samsung >> does not want to keep discussing. They just send random patches and >> disappear... >> >> Best regards, >> Krzysztof >> >> > > No. It's driver for Exynos. Currently It only has wakelocks but I will > submit one by one. Please think as the first patch of exynos not > squeezed. That's not how upstream kernel development works... Your code has nothing for Exynos. It's Android driver, not Exynos. If you say there is something for Exynos it must be visible here. Wakelocks are not relevant to Exynos, so after dropping them there would be empty stub in upstream kernel which obviously cannot be accepted. Best regards, Krzysztof