Re: [PATCH] USB: serial: option: Add Telit FT980-KS composition

[Leonid Bloch <leonidb@asocscloud.com>]

Lars,


Thank you for your review! The changes which you have suggested also 
made ModemManager to recognize the device (which it didn't do before). 
Please check out the v2.


Cheers,
Leonid.

___

On 10/4/20 5:32 PM, Lars Melin wrote:
> On 10/4/2020 21:16, Lars Melin wrote:
>> On 10/4/2020 20:29, Leonid Bloch wrote:
>>> On 10/4/20 1:58 PM, Lars Melin wrote:
>>>> On 10/4/2020 16:57, Leonid Bloch wrote:
>>>>> This commit adds the following Telit FT980-KS composition:
>>>>>
>>>>> 0x1054: rndis, diag, adb, nmea, modem, modem, aux
>>>>>
>>>>> AT commands can be sent to /dev/ttyUSB5.
>>>>>
>>>>
>>>> Please submit a verbose lsusb listing for the device, I can't imagine
>>>> that the adb interface should be handled by the option serial driver so
>>>> there will never be a ttyUSB5.
>>>
>>> Please see below.
>>>
>>> Thanks,
>>> Leonid.
>>>
>>> ```
>>> Bus 001 Device 005: ID 1bc7:1054 Telit Wireless Solutions
>>> Device Descriptor:
>>>     bLength                18
>>>     bDescriptorType         1
>>>     bcdUSB               2.10
>>>     bDeviceClass            0
>>>     bDeviceSubClass         0
>>>     bDeviceProtocol         0
>>>     bMaxPacketSize0        64
>>>     idVendor           0x1bc7 Telit Wireless Solutions
>>>     idProduct          0x1054
>>>     bcdDevice            4.14
>>>     iManufacturer           1 Telit Wireless Solutions
>>>     iProduct                2 FT980-KS
>>>     iSerial                 3 cb42f61
>>>     bNumConfigurations      1
>>>     Configuration Descriptor:
>>>       bLength                 9
>>>       bDescriptorType         2
>>>       wTotalLength       0x013d
>>>       bNumInterfaces          8
>>>       bConfigurationValue     1
>>>       iConfiguration          4 RNDIS_DIAG_ADB_NMEA_DUN_DUN_SER
>>>       bmAttributes         0xa0
>>>         (Bus Powered)
>>>         Remote Wakeup
>>>       MaxPower              500mA
>>>       Interface Association:
>>>         bLength                 8
>>>         bDescriptorType        11
>>>         bFirstInterface         0
>>>         bInterfaceCount         2
>>>         bFunctionClass        239 Miscellaneous Device
>>>         bFunctionSubClass       4
>>>         bFunctionProtocol       1
>>>         iFunction               7 RNDIS
>>>       Interface Descriptor:
>>>         bLength                 9
>>>         bDescriptorType         4
>>>         bInterfaceNumber        0
>>>         bAlternateSetting       0
>>>         bNumEndpoints           1
>>>         bInterfaceClass       239 Miscellaneous Device
>>>         bInterfaceSubClass      4
>>>         bInterfaceProtocol      1
>>>         iInterface              5 RNDIS Communications Control
>>>         ** UNRECOGNIZED:  05 24 00 10 01
>>>         ** UNRECOGNIZED:  05 24 01 00 01
>>>         ** UNRECOGNIZED:  04 24 02 00
>>>         ** UNRECOGNIZED:  05 24 06 00 01
>>>         Endpoint Descriptor:
>>>           bLength                 7
>>>           bDescriptorType         5
>>>           bEndpointAddress     0x81  EP 1 IN
>>>           bmAttributes            3
>>>             Transfer Type            Interrupt
>>>             Synch Type               None
>>>             Usage Type               Data
>>>           wMaxPacketSize     0x0008  1x 8 bytes
>>>           bInterval               9
>>>       Interface Descriptor:
>>>         bLength                 9
>>>         bDescriptorType         4
>>>         bInterfaceNumber        1
>>>         bAlternateSetting       0
>>>         bNumEndpoints           2
>>>         bInterfaceClass        10 CDC Data
>>>         bInterfaceSubClass      0
>>>         bInterfaceProtocol      0
>>>         iInterface              6 RNDIS Ethernet Data
>>>         Endpoint Descriptor:
>>>           bLength                 7
>>>           bDescriptorType         5
>>>           bEndpointAddress     0x8e  EP 14 IN
>>>           bmAttributes            2
>>>             Transfer Type            Bulk
>>>             Synch Type               None
>>>             Usage Type               Data
>>>           wMaxPacketSize     0x0200  1x 512 bytes
>>>           bInterval               0
>>>         Endpoint Descriptor:
>>>           bLength                 7
>>>           bDescriptorType         5
>>>           bEndpointAddress     0x0f  EP 15 OUT
>>>           bmAttributes            2
>>>             Transfer Type            Bulk
>>>             Synch Type               None
>>>             Usage Type               Data
>>>           wMaxPacketSize     0x0200  1x 512 bytes
>>>           bInterval               0
>>>       Interface Descriptor:
>>>         bLength                 9
>>>         bDescriptorType         4
>>>         bInterfaceNumber        2
>>>         bAlternateSetting       0
>>>         bNumEndpoints           2
>>>         bInterfaceClass       255 Vendor Specific Class
>>>         bInterfaceSubClass    255 Vendor Specific Subclass
>>>         bInterfaceProtocol     48
>>>         iInterface              0
>>>         Endpoint Descriptor:
>>>           bLength                 7
>>>           bDescriptorType         5
>>>           bEndpointAddress     0x82  EP 2 IN
>>>           bmAttributes            2
>>>             Transfer Type            Bulk
>>>             Synch Type               None
>>>             Usage Type               Data
>>>           wMaxPacketSize     0x0200  1x 512 bytes
>>>           bInterval               0
>>>         Endpoint Descriptor:
>>>           bLength                 7
>>>           bDescriptorType         5
>>>           bEndpointAddress     0x01  EP 1 OUT
>>>           bmAttributes            2
>>>             Transfer Type            Bulk
>>>             Synch Type               None
>>>             Usage Type               Data
>>>           wMaxPacketSize     0x0200  1x 512 bytes
>>>           bInterval               0
>>>       Interface Descriptor:
>>>         bLength                 9
>>>         bDescriptorType         4
>>>         bInterfaceNumber        3
>>>         bAlternateSetting       0
>>>         bNumEndpoints           2
>>>         bInterfaceClass       255 Vendor Specific Class
>>>         bInterfaceSubClass     66
>>>         bInterfaceProtocol      1
>>>         iInterface              8 ADB Interface
>>>         Endpoint Descriptor:
>>>           bLength                 7
>>>           bDescriptorType         5
>>>           bEndpointAddress     0x02  EP 2 OUT
>>>           bmAttributes            2
>>>             Transfer Type            Bulk
>>>             Synch Type               None
>>>             Usage Type               Data
>>>           wMaxPacketSize     0x0200  1x 512 bytes
>>>           bInterval               0
>>>         Endpoint Descriptor:
>>>           bLength                 7
>>>           bDescriptorType         5
>>>           bEndpointAddress     0x83  EP 3 IN
>>>           bmAttributes            2
>>>             Transfer Type            Bulk
>>>             Synch Type               None
>>>             Usage Type               Data
>>>           wMaxPacketSize     0x0200  1x 512 bytes
>>>           bInterval               0
>>
>> //snip
>>
>> Interface #3 for ADB must be blacklisted in the option entry for the
>> device, by using .driver_info = RSVD(3)
>>
> 
> 
> When looking at the entries for other Telit deices in the option driver
> I see that their diag interface always has
> the NCTRL flag so it is likely that you need that for this device also.
> See the entry for PID 1052
> 
> 
> thanks
> Lars
>