* uas: fix comparison for error code
@ 2018-03-06 14:04 Oliver Neukum
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Neukum @ 2018-03-06 14:04 UTC (permalink / raw)
To: gregkh, linux-usb, hdegoede; +Cc: Oliver Neukum, stable
A typo broke the comparison.
Fixes: cbeef22fd611c4f47c494b821b2b105b8af970bb ("usb: uas: unconditionally bring back host after reset")
Signed-off-by: Oliver Neukum <oneukum@suse.com>
CC: stable@kernel.org
---
drivers/usb/storage/uas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 3b1b9695177a..6034c39b67d1 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -1076,7 +1076,7 @@ static int uas_post_reset(struct usb_interface *intf)
return 0;
err = uas_configure_endpoints(devinfo);
- if (err && err != ENODEV)
+ if (err && err != -ENODEV)
shost_printk(KERN_ERR, shost,
"%s: alloc streams error %d after reset",
__func__, err);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* uas: fix comparison for error code
@ 2018-03-06 14:52 Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2018-03-06 14:52 UTC (permalink / raw)
To: Oliver Neukum, gregkh, linux-usb; +Cc: stable
Hi,
On 06-03-18 15:04, Oliver Neukum wrote:
> A typo broke the comparison.
>
> Fixes: cbeef22fd611c4f47c494b821b2b105b8af970bb ("usb: uas: unconditionally bring back host after reset")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> CC: stable@kernel.org
Thanks.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/usb/storage/uas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
> index 3b1b9695177a..6034c39b67d1 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -1076,7 +1076,7 @@ static int uas_post_reset(struct usb_interface *intf)
> return 0;
>
> err = uas_configure_endpoints(devinfo);
> - if (err && err != ENODEV)
> + if (err && err != -ENODEV)
> shost_printk(KERN_ERR, shost,
> "%s: alloc streams error %d after reset",
> __func__, err);
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-06 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-06 14:52 uas: fix comparison for error code Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2018-03-06 14:04 Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).