Linux USB
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Stanley Chang <stanley_chang@realtek.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] usb: dwc3: core: add support for realtek SoCs custom's global register start address
Date: Thu, 4 May 2023 10:50:15 +0300	[thread overview]
Message-ID: <96706396-7023-b895-169a-788aad11adcb@gmail.com> (raw)
In-Reply-To: <20230504034423.20813-1-stanley_chang@realtek.com>

Hello!

On 5/4/23 6:44 AM, Stanley Chang wrote:

> The Realtek RTD1xxx SoCs were designed, the global register address
> offset at 0x8100.

  Can't parse that, perhaps "with" is missing?

> The default address offset is constant at
> DWC3_GLOBALS_REGS_START (0xc100). Therefore, add a check if the
> compatible name of the parent is "realtek,rtd1xxx-dwc3", then global

   Wildcards are not allowed in the "compatible" props...

> register start address will remap to 0x8100.
> 
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
[...]

MBR, Sergey

  reply	other threads:[~2023-05-04  7:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04  3:44 [PATCH v5] usb: dwc3: core: add support for realtek SoCs custom's global register start address Stanley Chang
2023-05-04  7:50 ` Sergei Shtylyov [this message]
2023-05-04  8:26   ` Stanley Chang[昌育德]
2023-05-04  8:27     ` Sergei Shtylyov
2023-05-04  8:36       ` Stanley Chang[昌育德]
2023-05-04 15:45         ` Sergei Shtylyov
2023-05-05  2:17           ` Stanley Chang[昌育德]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96706396-7023-b895-169a-788aad11adcb@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stanley_chang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox