Re: [PATCH v4 1/3] usb: gadget: function: move u_f.h to include/linux/usb/

Alan Stern
2024-05-01T14:19:18Z

On Wed, May 01, 2024 at 10:38:11AM +0200, Michael Grzeschik wrote:
> On Mon, Apr 29, 2024 at 09:51:20PM -0400, Alan Stern wrote:
> > On Tue, Apr 30, 2024 at 01:33:26AM +0200, Michael Grzeschik wrote:
> > > We move the u_f.h header to include/linux/usb to be
> > > able to compile function drivers outside of the
> > > drivers/usb/gadget/function directory.
> > >
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> >
> > Given that you're moving a private header file to a public location,
> > don't you think it should now have a name that's more meaningful to
> > general kernel developers than "u_f.h"?
>
> Fair point.
>
> How about func_utils.h instead?

Yes, that would be a lot better. Especially if you put it in
include/linux/usb/gadget rather than include/linux/usb.

Thanks.

Alan Stern