From: Damien Le Moal <dlemoal@kernel.org>
To: John Garry <john.g.garry@oracle.com>,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, bvanassche@acm.org,
linux-s390@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-usb@vger.kernel.org, John Garry <john.garry@linux.dev>
Subject: Re: [PATCH v2] scsi: core: Drop Scsi_Host.default_lock
Date: Thu, 6 Aug 2026 09:30:34 -0700 [thread overview]
Message-ID: <9bd395e3-5df4-4e13-886f-b1afeeb5d4a2@kernel.org> (raw)
In-Reply-To: <20260806113958.3127942-1-john.g.garry@oracle.com>
On 2026/08/06 4:39, John Garry wrote:
> From: John Garry <john.garry@linux.dev>
>
> Back in the 2.6.xx days, it was possible to for low-level drivers to set
s/to for/for
> the shost lock pointer. That is why there is a default lock and a pointer
> to the shost lock.
>
> However, support for this has long been removed, so drop
> Scsi_Host.default_lock and make Scsi_Host.host_lock as the actual lock.
>
> Getting the address of embedded host_lock structure just requires adding
> a fixed offset value to the shost pointer. However, getting the value of
> the host_lock pointer requires loading from a fixed offset to the shost
> pointer. The latter should be very slightly slower, which is relevant as
> this lock is used a lot throughout the core code and drivers.
>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
For the ata bits,
Acked-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-08-06 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 11:39 [PATCH v2] scsi: core: Drop Scsi_Host.default_lock John Garry
2026-08-06 16:30 ` Damien Le Moal [this message]
2026-08-06 17:15 ` Bart Van Assche
2026-08-07 8:18 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd395e3-5df4-4e13-886f-b1afeeb5d4a2@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=john.g.garry@oracle.com \
--cc=john.garry@linux.dev \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox