From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C0BC77B76 for ; Mon, 17 Apr 2023 15:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230498AbjDQPJK (ORCPT ); Mon, 17 Apr 2023 11:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbjDQPJJ (ORCPT ); Mon, 17 Apr 2023 11:09:09 -0400 X-Greylist: delayed 15688 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 17 Apr 2023 08:09:05 PDT Received: from sender4-op-o10.zoho.com (sender4-op-o10.zoho.com [136.143.188.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28246A240; Mon, 17 Apr 2023 08:09:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681744136; cv=none; d=zohomail.com; s=zohoarc; b=iyfGYLw59aNAdVJNqZF6Ocs8uPg34ZQrFTLNzVBc1Kc2k0s05PV2m7TB5E94iEhMpGLzOiAWqXO6VbvTRpSjQMMw3ueTQptFHBTmtlTray/KFKtAkO8Xs0FKEDrjry8csjscHYuo88vqo7wKQMvTFVeojWScoEBfsNgYf4Q8twk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681744136; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=hD23he8/NvWp3mSckDAig6IJhCBzSuHzGFxZ+hV+vm8=; b=Ry9PNWjaGsOCJE3fT26Ds5G1UfGm5FPuUr2HCp5prlmH86kensZgclL0coTjqf4lc6tDwPD1B3yTt+AUYlWHcjUucuQUGC3YemJPFMI9yLAIbPlzs9o1AUwXgSh1kkz+DYd/c8/qzpYrNHqkQZPiGJdgYTiNRXOwKuHIzKAljHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1681744136; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=hD23he8/NvWp3mSckDAig6IJhCBzSuHzGFxZ+hV+vm8=; b=RAoUobvU2EkG6SuPD5VgWhuTwcGholRbzxoaOQ1aW/+jB99nz2vtPI0q0xvgs9p2 oQ5fLZhFmTvfcVvoRTu1xkOWUrOUaA+qTY+uFeDK/N6bSZB5jkTsrjlErpZFus49hCh c7nwLPdsDwtQSMlwYPv4ndneehBD596K/MPQQmTk= Received: from [10.10.10.3] (149.91.1.15 [149.91.1.15]) by mx.zohomail.com with SMTPS id 168174413416427.811981668877024; Mon, 17 Apr 2023 08:08:54 -0700 (PDT) Message-ID: <9d51c222-8200-8943-aeef-a19b0e1739fe@arinc9.com> Date: Mon, 17 Apr 2023 18:08:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] USB: serial: option: add UNISOC vendor and TOZED LT70C product To: Johan Hovold Cc: Greg Kroah-Hartman , =?UTF-8?Q?Bj=c3=b8rn_Mork?= , me@1conan.com, erkin.bozoglu@xeront.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230406055004.8216-1-arinc.unal@arinc9.com> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 17.04.2023 17:19, Johan Hovold wrote: > On Mon, Apr 17, 2023 at 01:42:05PM +0300, Arınç ÜNAL wrote: >> On 13.04.2023 18:14, Johan Hovold wrote: >>> On Thu, Apr 06, 2023 at 08:50:04AM +0300, arinc9.unal@gmail.com wrote: >>>> From: Arınç ÜNAL >>>> >>>> Add UNISOC vendor ID and TOZED LT70-C modem which is based from UNISOC >>>> SL8563. The modem supports the NCM mode. >>> >>> Thanks for the patch. Looks mostly good, but see my comments below. >> >> Thanks a lot for looking at this Johan! >> >>> >>>> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 6 Spd=480 MxCh= 0 >>>> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 >>>> P: Vendor=1782 ProdID=4055 Rev=04.04 >>>> S: Manufacturer=Unisoc Phone >>>> S: Product=Unisoc Phone >>>> S: SerialNumber= >>>> C: #Ifs=14 Cfg#= 1 Atr=c0 MxPwr=500mA >>>> I: If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm >>>> E: Ad=82(I) Atr=03(Int.) MxPS= 16 Ivl=32ms >>>> I: If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm >>>> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#=10 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >>>> E: Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=8b(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#=11 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >>>> E: Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=8c(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#=12 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=option >>>> E: Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=8d(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>> >>> This looks like an ADB interface which should be blacklisted (reserved) >>> so that the driver does not bind to it. >> >> Will do. >> >>> >>>> I: If#=13 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >>>> E: Ad=0a(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#= 2 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm >>>> E: Ad=84(I) Atr=03(Int.) MxPS= 16 Ivl=32ms >>>> I: If#= 3 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm >>>> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#= 4 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm >>>> E: Ad=86(I) Atr=03(Int.) MxPS= 16 Ivl=32ms >>>> I: If#= 5 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm >>>> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#= 6 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm >>>> E: Ad=88(I) Atr=03(Int.) MxPS= 16 Ivl=32ms >>>> I: If#= 7 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm >>>> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >>>> E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> I: If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >>>> E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >>>> E: Ad=8a(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >>>> --- >>>> drivers/usb/serial/option.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >>>> index f31cc3c76329..65a050a9ca39 100644 >>>> --- a/drivers/usb/serial/option.c >>>> +++ b/drivers/usb/serial/option.c >>>> @@ -595,6 +595,11 @@ static void option_instat_callback(struct urb *urb); >>>> #define SIERRA_VENDOR_ID 0x1199 >>>> #define SIERRA_PRODUCT_EM9191 0x90d3 >>>> >>>> +/* UNISOC (Spreadtrum) products */ >>>> +#define UNISOC_VENDOR_ID 0x1782 >>>> +/* TOZED TL70-C based on UNISOC SL8563 uses UNISOC's vendor ID */ >>>> +#define TOZED_PRODUCT_LT70C 0x4055 >>>> + >>>> /* Device flags */ >>>> >>>> /* Highest interface number which can be used with NCTRL() and RSVD() */ >>>> @@ -2225,6 +2230,7 @@ static const struct usb_device_id option_ids[] = { >>>> { USB_DEVICE_AND_INTERFACE_INFO(OPPO_VENDOR_ID, OPPO_PRODUCT_R11, 0xff, 0xff, 0x30) }, >>>> { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0xff, 0x30) }, >>>> { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0, 0) }, >>>> + { USB_DEVICE(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C) }, >>> >>> You should match also on the interface class so that you don't try to >>> bind to the cdc interfaces. See USB_DEVICE_INTERFACE_CLASS() (and >>> RSVD() for the ADB interface). >> >> Thanks, the final result should look like this: >> >> { USB_DEVICE_INTERFACE_CLASS(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C, 0xff), >> .driver_info = RSVD(12) }, > > Alternatively, it looks like you could use > USB_DEVICE_AND_INTERFACE_INFO() and match on ff/0/0. That's generally > preferred as it works also if the interface numbers can change. Sounds good. I also don't need to use RSVD() since this won't match the ADB interface if I understand correctly. I'll send v2 in a short moment. Arınç