From: Bastien Nocera <hadess@hadess.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Lucas Tanure <tanure@linux.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: apple-mfi-fastcharge: Fix use after free in probe
Date: Fri, 04 Dec 2020 10:46:54 +0100 [thread overview]
Message-ID: <9d9568fe9e1d5c00eab345c212ad0fa8cbcbc350.camel@hadess.net> (raw)
In-Reply-To: <X8ik4j8yJitVUyfU@mwanda>
On Thu, 2020-12-03 at 11:42 +0300, Dan Carpenter wrote:
> This code frees "mfi" and then derefences it on the next line to get
> the error code.
>
> Fixes: b0eec52fbe63 ("USB: apple-mfi-fastcharge: Fix kfree after
> failed kzalloc")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for catching that.
Reviewed-by: Bastien Nocera <hadess@hadess.net>
prev parent reply other threads:[~2020-12-04 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 8:42 [PATCH] USB: apple-mfi-fastcharge: Fix use after free in probe Dan Carpenter
2020-12-04 9:46 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9568fe9e1d5c00eab345c212ad0fa8cbcbc350.camel@hadess.net \
--to=hadess@hadess.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tanure@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox