From: Krzysztof Kozlowski <krzk@kernel.org>
To: Junzhong Pan <panjunzhong@linux.spacemit.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Chen <peter.chen@kernel.org>, Xu Yang <xu.yang_2@nxp.com>,
Peng Fan <peng.fan@nxp.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Yixun Lan <dlan@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
spacemit@lists.linux.dev,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v6 1/5] dt-bindings: usb: ci-hdrc-usb2: add spacemit,k1-usb2 compatible
Date: Thu, 19 Nov 2026 15:08:59 +0100 [thread overview]
Message-ID: <9db379cc-0b07-4efc-a3eb-ebc07e7952c7@kernel.org> (raw)
In-Reply-To: <20261119-b4-spacemit-k1-usb2-v6-1-4a9add848728@linux.spacemit.com>
On 19/11/2026 14:41, Junzhong Pan wrote:
> The USB2.0 controller on the SpacemiT K1 SoC is dual-role capable but
> has no internal OTG registers, this requires flags which disable
> related features set in platform data. Add a compatible string to match
> the platform data.
>
> Chipidea USB2 Controller on SpacemiT K1 requires 1 clock and 1 reset to
> work, add constraints for it.
>
> Reviewed-by: Yixun Lan <dlan@kernel.org>
Hm, I could not locate this tag. Where did it happen?
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Junzhong Pan <panjunzhong@linux.spacemit.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> index 620b564914d4..5c2b7eb1a6ff 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> @@ -25,6 +25,7 @@ properties:
> - nvidia,tegra124-udc
> - nxp,s32g2-usb
> - qcom,ci-hdrc
> + - spacemit,k1-usb2
> - items:
> - enum:
> - nvidia,tegra114-ehci
> @@ -113,6 +114,20 @@ allOf:
> maxItems: 2
> clock-names:
> maxItems: 2
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: spacemit,k1-usb2
> + then:
> + properties:
> + clocks:
> + maxItems: 1
Were are the clock-names constraints?
> + resets:
> + minItems: 1
This is odd. Why do you need minItems? What are the constraints?
This looks just wrong...
> + required:
> + - clocks
> + - resets
>
> unevaluatedProperties: false
>
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-19 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 13:41 [PATCH v6 0/5] Add SpacemiT K1 USB2.0 controllers support Junzhong Pan
2026-11-19 13:41 ` [PATCH v6 1/5] dt-bindings: usb: ci-hdrc-usb2: add spacemit,k1-usb2 compatible Junzhong Pan
2026-11-19 13:44 ` sashiko-bot
2026-11-19 14:08 ` Krzysztof Kozlowski [this message]
2026-11-19 13:41 ` [PATCH v6 2/5] usb: chipidea: usb2: use devm_clk_get_optional_enabled() Junzhong Pan
2026-11-19 13:44 ` sashiko-bot
2026-11-19 13:41 ` [PATCH v6 3/5] usb: chipidea: usb2: drop the ci_hdrc_usb2_priv wrapper struct Junzhong Pan
2026-11-19 13:44 ` sashiko-bot
2026-11-19 13:41 ` [PATCH v6 4/5] usb: chipidea: usb2: add optional reset support Junzhong Pan
2026-11-19 13:49 ` sashiko-bot
2026-11-19 13:41 ` [PATCH v6 5/5] usb: chipidea: usb2: add SpacemiT K1 support Junzhong Pan
2026-11-19 13:45 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9db379cc-0b07-4efc-a3eb-ebc07e7952c7@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=panjunzhong@linux.spacemit.com \
--cc=peng.fan@nxp.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox