From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Michael Bommarito <michael.bommarito@gmail.com>,
Sam Day <me@samcday.com>, Kees Cook <kees@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: f_fs: fix __le16 of wMaxPacketSize
Date: Mon, 13 Jul 2026 07:00:30 +0100 [thread overview]
Message-ID: <9f7cbd43-16e1-495e-8f56-9bce8fa5e437@codethink.co.uk> (raw)
In-Reply-To: <2026071124-gracious-spry-9b7b@gregkh>
On 11/07/2026 06:09, Greg Kroah-Hartman wrote:
> On Fri, Jul 10, 2026 at 03:54:30PM +0100, Ben Dooks wrote:
>> The wMaxPacketSize is __le16 type, fix the sparse warnings by changing
>> the type.
>>
>> Fixes the following sparse warnings:
>> drivers/usb/gadget/function/f_fs.c:3346:32: warning: incorrect type in assignment (different base types)
>> drivers/usb/gadget/function/f_fs.c:3346:32: expected unsigned short [usertype] wMaxPacketSize
>> drivers/usb/gadget/function/f_fs.c:3346:32: got restricted __le16 [usertype] wMaxPacketSize
>> drivers/usb/gadget/function/f_fs.c:3371:36: warning: incorrect type in assignment (different base types)
>> drivers/usb/gadget/function/f_fs.c:3371:36: expected restricted __le16 [usertype] wMaxPacketSize
>> drivers/usb/gadget/function/f_fs.c:3371:36: got unsigned short [usertype] wMaxPacketSize
>>
>> Fixes: dcc03cef0fd8 ("usb: gadget: f_fs: preserve wMaxPacketSize across usb_ep_autoconfig() call")
>
> This isn't a valid git id :(
Looks like the b got dropped off the front during copy.
Fixes: bdcc03cef0fd8 ("usb: gadget: f_fs: preserve wMaxPacketSize across
usb_ep_autoconfig() call")
commit bdcc03cef0fd8abc6eaeec6ac47e54ae8f8c625f
Author: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Date: Thu Jan 31 15:53:40 2019 +0100
usb: gadget: f_fs: preserve wMaxPacketSize across
usb_ep_autoconfig() call
usb_ep_autoconfig() treats the passed descriptor as if it were an fs
descriptor. In particular, for bulk endpoints, it clips wMaxPacketSize
to 64. This patch preserves the original value.
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2026-07-13 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 14:54 [PATCH v2] usb: gadget: f_fs: fix __le16 of wMaxPacketSize Ben Dooks
2026-07-11 5:09 ` Greg Kroah-Hartman
2026-07-13 6:00 ` Ben Dooks [this message]
2026-07-13 6:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f7cbd43-16e1-495e-8f56-9bce8fa5e437@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=me@samcday.com \
--cc=michael.bommarito@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox