From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 464F41B29D9 for ; Mon, 9 Sep 2024 09:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725874179; cv=none; b=En/nK7kkXElysqaWLF/SaU+CNj3rJeWrHCAg0brKGGytScZnuT82rU7XOAcEF67Se745g4sXt9J3iNhDdivfjJnMA112pxRKuCRxOG0gA+Eu8BqN9jL0RgE3blyZB0DVCTX/I2o/OW2LVHZbUXfpqO3CG1LX3W4t6IO1+bOoycc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725874179; c=relaxed/simple; bh=BN4tazxh3rpRIAWwNqOVoPdvVfcO1FwnyEStibweItQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ajgJJUCRQ3ceCo5f4J+tN6RMG7TctgDGf378GPYXTcvuicn1HvLqjI5AN+8/4Ot9AUIRTaUOh71KsP3i2dliFSClwIRDXXXRemSYWJgaHXEDnheJgLYNB6JFrzHRdOAr7zkDTwJS7eKDqL17zpRVZgJ/EefmfDeBH7+5xaX39ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=e9/wegB+; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="e9/wegB+" Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 84DF33F20C for ; Mon, 9 Sep 2024 09:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1725874172; bh=1s6ErxBpBnN4TDCj/24ykKeIJzZtbIIx8kz5Yh/iY7Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e9/wegB+0/e64FXmg6K+JwOGQHoA0k0jqeKMe1KSS+SRq9YbTiRVIzjuaiCE0hnhi I0SYg6nmOqQNB81Gl+j1PAyTAL3Upy95cFwD8W/kywPyxgCNMvCGTAPegzmFGMAtJa t4GeEDCjYAvltNDsBSnbtFLhnQvGLz/ERfnb43l4RkuzVXcIJdCJ+Pmt5mrxV8Qv+u ASb1RP8gNP+Otihi91RzdFRf/tLKrOnQNoWWnTYPdXAShK8cs793cqpQjcg9oJW9kY Q4YhIEcyn+LZnBlgOCtGyZLv1XvR2PjISvjBCscqX85LNhETTb1PC6x97hCJrokaA/ UwcutdPQg2HnQ== Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2053f49d0c9so55672595ad.1 for ; Mon, 09 Sep 2024 02:29:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725874171; x=1726478971; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1s6ErxBpBnN4TDCj/24ykKeIJzZtbIIx8kz5Yh/iY7Y=; b=Cx0UtGqvyQ/fsztotg4txxCkC5Y7q4t26WIsIwkLxW9ZRUXQsg1juV18Isrw+tTsZG QKx0gdzEFA5BqnCp+8szoqy/qzwKtHHGZa4kf/F4vmT7q0lbOOBv6eUyOo2tCqFeoHM9 GKikTWwi/TH0tP/KQF4NKJeMV/KqQrwciWkD7RcQBBrjyqHjiflTFGt7E/11Xw+EYx2D Ms91AyINjfdiNw8s8UiZpHUc09glQzOnugZbJ+quW/i4Gaj5VQ2BJAZ6aL29+oShWuOk hCmX9aoiDw/HDxvM0vTHgJDJnH0xffB0ie0J+CSe7PXOhs5j0G7bMT9OVsMSDGZDa5kG tshA== X-Gm-Message-State: AOJu0YxvRNRMkjq6D6n1hefvsuB0vawQda72cpcaQH0UtIW9mqoJeR/5 HwvEB/aFebx8Ucw9nrqYSIXDMvZl+siWtOojMDnWfoRCnY0GcLWZ5SHGgitwqj0r4Ui67idPqA3 y+loqLahq7Ufne2Y8GFwS463osxXFdQ6LFvQCegMtmJjv4XJocHEU9VFSmx9yVsnnFPS9EYW2mg == X-Received: by 2002:a17:902:ce91:b0:206:b5b8:25dd with SMTP id d9443c01a7336-206eeb7a78bmr170498235ad.23.1725874171064; Mon, 09 Sep 2024 02:29:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOj9jqwDDJjKtB8eNNDnBjTUzIZm4sDUYK04l69QZOWzQRdEeA2WvR6/1IBLED1Y1FZtDrUw== X-Received: by 2002:a17:902:ce91:b0:206:b5b8:25dd with SMTP id d9443c01a7336-206eeb7a78bmr170497875ad.23.1725874170361; Mon, 09 Sep 2024 02:29:30 -0700 (PDT) Received: from [127.0.0.1] ([103.172.41.204]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e3757csm30355605ad.112.2024.09.09.02.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2024 02:29:29 -0700 (PDT) Message-ID: <9fddd930-21ae-4e7d-86ee-c586af3b50e0@canonical.com> Date: Mon, 9 Sep 2024 17:29:23 +0800 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v2] usb: musb: mediatek: Simplify code with dev_err_probe() To: Lin Ruifeng , b-liu@ti.com, gregkh@linuxfoundation.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20240907081351.19879-1-linruifeng4@huawei.com> Content-Language: en-US From: Guoqing Jiang In-Reply-To: <20240907081351.19879-1-linruifeng4@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/7/24 16:13, Lin Ruifeng wrote: > The combination of dev_err() and the returned error code could be > replaced by dev_err_probe() in driver's probe function. Let's, > converting to dev_err_probe() to make code more simple. > > Signed-off-by: Lin Ruifeng > --- > v2: > - The wrong message is modified. > drivers/usb/musb/mediatek.c | 27 +++++++++++---------------- > 1 file changed, 11 insertions(+), 16 deletions(-) > > diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c > index 0a35aab3ab81..63c86c046b98 100644 > --- a/drivers/usb/musb/mediatek.c > +++ b/drivers/usb/musb/mediatek.c > @@ -416,10 +416,9 @@ static int mtk_musb_probe(struct platform_device *pdev) > return -ENOMEM; > > ret = of_platform_populate(np, NULL, NULL, dev); > - if (ret) { > - dev_err(dev, "failed to create child devices at %p\n", np); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, > + "failed to create child devices at %p\n", np); > > ret = mtk_musb_clks_get(glue); > if (ret) > @@ -448,23 +447,19 @@ static int mtk_musb_probe(struct platform_device *pdev) > glue->role = USB_ROLE_NONE; > break; > default: > - dev_err(&pdev->dev, "Error 'dr_mode' property\n"); > - return -EINVAL; > + return dev_err_probe(&pdev->dev, -EINVAL, > + "Error 'dr_mode' property\n"); > } > > glue->phy = devm_of_phy_get_by_index(dev, np, 0); > - if (IS_ERR(glue->phy)) { > - dev_err(dev, "fail to getting phy %ld\n", > - PTR_ERR(glue->phy)); > - return PTR_ERR(glue->phy); > - } > + if (IS_ERR(glue->phy)) > + return dev_err_probe(dev, PTR_ERR(glue->phy), > + "fail to getting phy\n"); > > glue->usb_phy = usb_phy_generic_register(); > - if (IS_ERR(glue->usb_phy)) { > - dev_err(dev, "fail to registering usb-phy %ld\n", > - PTR_ERR(glue->usb_phy)); > - return PTR_ERR(glue->usb_phy); > - } > + if (IS_ERR(glue->usb_phy)) > + return dev_err_probe(dev, PTR_ERR(glue->usb_phy), > + "fail to registering usb-phy\n"); > > glue->xceiv = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2); > if (IS_ERR(glue->xceiv)) { Sorry, this is probably out of topic. I had seen one relevant kmemleak report (probably false positive) which is related to dev_err_probe. [] kmemleak_alloc+0xe0/0x120 [] __kmalloc_node_track_caller+0x354/0x4d0 [] kvasprintf+0xd0/0x1a0 [] kasprintf+0xac/0x120 [] device_set_deferred_probe_reason+0x68/0x148 [] dev_err_probe+0x164/0x1b0 [] __clk_bulk_get+0x108/0x238 [] clk_bulk_get_optional+0x20/0x50 [] devm_clk_bulk_get_optional+0x6c/0x160 [] mtk_tphy_probe+0x38c/0x7a8 [] platform_probe+0xd0/0x240 [] really_probe+0x368/0xa10 [] __driver_probe_device+0x170/0x420 [] driver_probe_device+0x68/0x1f0 [] __driver_attach+0x234/0x558 [] bus_for_each_dev+0x108/0x1c8 Not sure if this patch could trigger the same report. Thanks, Guoqing