From: Daniel Almeida <daniel.almeida@collabora.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 24/27] rust: usb: add __rust_helper to helpers
Date: Mon, 5 Jan 2026 10:40:04 -0300 [thread overview]
Message-ID: <C2DE044A-4CC6-4C4E-BC26-ADF46055940F@collabora.com> (raw)
In-Reply-To: <20260105-define-rust-helper-v2-24-51da5f454a67@google.com>
> On 5 Jan 2026, at 09:42, Alice Ryhl <aliceryhl@google.com> wrote:
>
> This is needed to inline these helpers into Rust code.
>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
> Reviewed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: Daniel Almeida <daniel.almeida@collabora.com>
> ---
> rust/helpers/usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/rust/helpers/usb.c b/rust/helpers/usb.c
> index fb2aad0cbf4d26ac7fb1a3f176ee7a1d30800f92..eff1cf7be3c2d10b7e9248252d354eb8a4fd4c94 100644
> --- a/rust/helpers/usb.c
> +++ b/rust/helpers/usb.c
> @@ -2,7 +2,8 @@
>
> #include <linux/usb.h>
>
> -struct usb_device *rust_helper_interface_to_usbdev(struct usb_interface *intf)
> +__rust_helper struct usb_device *
> +rust_helper_interface_to_usbdev(struct usb_interface *intf)
> {
> return interface_to_usbdev(intf);
> }
>
> --
> 2.52.0.351.gbe84eed79e-goog
>
>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
next prev parent reply other threads:[~2026-01-05 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 12:42 [PATCH v2 00/27] Allow inlining C helpers into Rust when using LTO Alice Ryhl
2026-01-05 12:42 ` [PATCH v2 24/27] rust: usb: add __rust_helper to helpers Alice Ryhl
2026-01-05 13:40 ` Daniel Almeida [this message]
2026-01-05 15:41 ` [PATCH v2 00/27] Allow inlining C helpers into Rust when using LTO Boqun Feng
2026-01-26 5:08 ` Miguel Ojeda
2026-03-10 10:56 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2DE044A-4CC6-4C4E-BC26-ADF46055940F@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=aliceryhl@google.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox