From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org,
syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com,
Stable <stable@vger.kernel.org>
Subject: usbip: vhci_hcd: check port number before using
Date: Mon, 8 Oct 2018 21:01:13 +0100 [thread overview]
Message-ID: <CADVatmOZ943m_bmXS9vQs8Fy73aaG1PNP1YCzX-J2HN_f5Zigw@mail.gmail.com> (raw)
On Mon, Oct 8, 2018 at 8:29 PM Shuah Khan <shuah@kernel.org> wrote:
>
> Hi Sudip,
>
> On 10/08/2018 01:19 PM, Sudip Mukherjee wrote:
> > From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> >
> > The port number is checked and it just prints an error message but it
> > still continues to use the invalid port. And as a result it accesses
> > memory which is not its resulting in BUG report from KASAN.
>
> Yes there is an issue with out of bounds access. But this isn't the
> right fix.
>
> >
> > Reported-by: syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>
> I sent in a fix for this last Friday.
>
> https://patchwork.kernel.org/patch/10628833/
And I can confirm this patch also fixes the issue tested with the
reproducer I was using in my vm.
next reply other threads:[~2018-10-08 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 20:01 Sudip Mukherjee [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-08 20:06 usbip: vhci_hcd: check port number before using Shuah Khan
2018-10-08 19:28 Shuah Khan
2018-10-08 19:19 Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADVatmOZ943m_bmXS9vQs8Fy73aaG1PNP1YCzX-J2HN_f5Zigw@mail.gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).