From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-amlogic@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v2 2/3] usb: dwc3: meson-g12a: fix shared reset control use
Date: Sat, 5 Dec 2020 22:42:30 +0100 [thread overview]
Message-ID: <CAFBinCCovB9e1_AwXv0Jcn3p69LN5KAdzttfZcY+=_TEZTCn6Q@mail.gmail.com> (raw)
In-Reply-To: <20201201190100.17831-3-aouledameur@baylibre.com>
Hello Amjad,
On Tue, Dec 1, 2020 at 8:01 PM Amjad Ouled-Ameur
<aouledameur@baylibre.com> wrote:
>
> reset_control_(de)assert() calls are called on a shared reset line when
> reset_control_reset has been used. This is not allowed by the reset
> framework.
>
> Use reset_control_rearm() call in suspend() and remove() as a way to state
> that the resource is no longer used, hence the shared reset line
> may be triggered again by other devices. Use reset_control_rearm() also in
> case probe fails after reset() has been called.
>
> reset_control_rearm() keeps use of triggered_count sane in the reset
> framework, use of reset_control_reset() on shared reset line should be
> balanced with reset_control_rearm().
I think this should be updated after [0] is applied
The goto from that patch needs to use err_rearm from this patch.
Best regards,
Martin
[0] https://patchwork.kernel.org/project/linux-usb/patch/20201111095256.10477-1-zhengzengkai@huawei.com/
next prev parent reply other threads:[~2020-12-05 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 19:00 [PATCH v2 0/3] usb: meson: fix shared reset control use Amjad Ouled-Ameur
2020-12-01 19:00 ` [PATCH v2 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use Amjad Ouled-Ameur
2020-12-05 21:53 ` Martin Blumenstingl
2020-12-01 19:00 ` [PATCH v2 2/3] usb: dwc3: meson-g12a: fix shared reset control use Amjad Ouled-Ameur
2020-12-05 21:42 ` Martin Blumenstingl [this message]
2020-12-10 17:35 ` Amjad Ouled-Ameur
2020-12-01 19:01 ` [PATCH v2 3/3] phy: amlogic: meson8b-usb2: " Amjad Ouled-Ameur
2020-12-05 21:40 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCCovB9e1_AwXv0Jcn3p69LN5KAdzttfZcY+=_TEZTCn6Q@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=aouledameur@baylibre.com \
--cc=balbi@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).