Re: [PATCH v9 4/4] USB: Pass PMSG_POWEROFF event to suspend_common()

["Rafael J. Wysocki" <rafael@kernel.org>]

On Mon, Nov 3, 2025 at 9:10 PM Mario Limonciello (AMD) (kernel.org)
<superm1@kernel.org> wrote:
>
>
>
> On 11/3/2025 2:09 PM, Rafael J. Wysocki wrote:
> > On Sun, Oct 26, 2025 at 6:09 AM Mario Limonciello (AMD)
> > <superm1@kernel.org> wrote:
> >>
> >> suspend_common() passes a PM message indicating what type of event
> >> is occurring.  PMSG_POWEROFF is intended to be used when hibernate
> >> callbacks were utilized for turning off the system.
> >>
> >> Add a new callback hcd_pci_poweroff() which will
> >> determine if target state is power off and pass PMSG_POWEROFF as the
> >> message.
> >>
> >> suspend_common() doesn't do any special handling with this case at
> >> the moment, so there are no functional changes in this patch.
> >>
> >> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
> >> ---
> >> v9:
> >>   * Reword commit message (Bjorn)
> >> v8:
> >>   * Drop SYSTEM_HALT case
> >> v7:
> >>   * Reword commit mesasge
> >> v6:
> >>   * Fix LKP robot issue without CONFIG_PM_SLEEP
> >> v5:
> >>   * New patch
> >> v4:
> >>   * https://lore.kernel.org/linux-pci/20250616175019.3471583-1-superm1@kernel.org/
> >> ---
> >>   drivers/usb/core/hcd-pci.c | 11 ++++++++++-
> >>   1 file changed, 10 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
> >> index cd223475917ef..959baccfb07d1 100644
> >> --- a/drivers/usb/core/hcd-pci.c
> >> +++ b/drivers/usb/core/hcd-pci.c
> >> @@ -6,6 +6,7 @@
> >>   #include <linux/kernel.h>
> >>   #include <linux/module.h>
> >>   #include <linux/pci.h>
> >> +#include <linux/pm.h>
> >>   #include <linux/usb.h>
> >>   #include <linux/usb/hcd.h>
> >>
> >> @@ -531,6 +532,13 @@ static int hcd_pci_freeze(struct device *dev)
> >>          return suspend_common(dev, PMSG_FREEZE);
> >>   }
> >>
> >> +static int hcd_pci_poweroff(struct device *dev)
> >> +{
> >> +       if (system_state == SYSTEM_POWER_OFF)
> >> +               return suspend_common(dev, PMSG_POWEROFF);
> >> +       return suspend_common(dev, PMSG_SUSPEND);
> >> +}
> >> +
> >>   static int hcd_pci_suspend_noirq(struct device *dev)
> >>   {
> >>          struct pci_dev          *pci_dev = to_pci_dev(dev);
> >> @@ -602,6 +610,7 @@ static int hcd_pci_restore(struct device *dev)
> >>   #define hcd_pci_suspend                NULL
> >>   #define hcd_pci_freeze                 NULL
> >>   #define hcd_pci_suspend_noirq  NULL
> >> +#define hcd_pci_poweroff       NULL
> >>   #define hcd_pci_poweroff_late  NULL
> >>   #define hcd_pci_resume_noirq   NULL
> >>   #define hcd_pci_resume         NULL
> >> @@ -639,7 +648,7 @@ const struct dev_pm_ops usb_hcd_pci_pm_ops = {
> >>          .freeze_noirq   = check_root_hub_suspended,
> >>          .thaw_noirq     = NULL,
> >>          .thaw           = hcd_pci_resume,
> >> -       .poweroff       = hcd_pci_suspend,
> >> +       .poweroff       = hcd_pci_poweroff,
> >>          .poweroff_late  = hcd_pci_poweroff_late,
> >>          .poweroff_noirq = hcd_pci_suspend_noirq,
> >>          .restore_noirq  = hcd_pci_resume_noirq,
> >> --
> >
> > I would defer this patch until you know what exactly suspend_common()
> > will do for PMSG_POWEROFF because it may just be simpler to check
> > system_state == SYSTEM_POWER_OFF in it internally.
>
> OK - in that case would you just take the first 3 for 6.19?

I still need to go through them once again, but overall that's the plan.