From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc3: of-simple: fix use-after-free on remove From: "Rafael J. Wysocki" Message-Id: Date: Thu, 21 Jun 2018 00:55:26 +0200 To: Johan Hovold Cc: "Rafael J. Wysocki" , Tony Lindgren , Felipe Balbi , Roger Quadros , Tero Kristo , Greg Kroah-Hartman , Alan Stern , "open list:ULTRA-WIDEBAND \(UWB\) SUBSYSTEM:" , "Nori, Sekhar" , Grygorii Strashko , Nishanth Menon , Linux PM List-ID: T24gVGh1LCBKdW4gMjEsIDIwMTggYXQgMTI6MzIgQU0sIFJhZmFlbCBKLiBXeXNvY2tpIDxyYWZh ZWxAa2VybmVsLm9yZz4gd3JvdGU6Cj4gT24gV2VkLCBKdW4gMjAsIDIwMTggYXQgNTo0NiBQTSwg Sm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPiB3cm90ZToKPj4gT24gV2VkLCBKdW4gMjAs IDIwMTggYXQgMDI6NTQ6MTBQTSArMDIwMCwgUmFmYWVsIEouIFd5c29ja2kgd3JvdGU6Cj4+PiBP biBXZWRuZXNkYXksIEp1bmUgMjAsIDIwMTggMjoyMzo0NiBQTSBDRVNUIEpvaGFuIEhvdm9sZCB3 cm90ZToKPj4+ID4gT24gV2VkLCBKdW4gMjAsIDIwMTggYXQgMDI6MTY6NTlBTSAtMDcwMCwgVG9u eSBMaW5kZ3JlbiB3cm90ZToKPj4+ID4gPiBIaSwKPj4+ID4gPgo+Pj4gPiA+IEFkZGluZyBSYWZh ZWwgYW5kIGxpbnV4LXBtIHRvIENjIGFzIHdlbGwuCj4+PiA+ID4KPj4+ID4gPiAqIEZlbGlwZSBC YWxiaSA8YmFsYmlAa2VybmVsLm9yZz4gWzE4MDYxOSAwMToyM106Cj4+PiA+ID4gPiBUaGlzIGlz IGEgZGlyZWN0IGNvbnNlcXVlbmNlIG9mIG5vdCBwYXlpbmcgYXR0ZW50aW9uIHRvIHRoZSBvcmRl ciBvZgo+Pj4gPiA+ID4gdGhpbmdzLiBJZiBkcml2ZXIgd2VyZSB0byBhc3N1bWUgdGhhdCBwbV9k b21haW4tPmFjdGl2YXRlKCkgd291bGQgZG8gdGhlCj4+PiA+ID4gPiByaWdodCB0aGluZyBmb3Ig dGhlIGRldmljZSAtLSBtZWFuaW5nIHRoYXQgcHJvYmUgd291bGQgcnVuIHdpdGggYW4KPj4+ID4g PiA+IGFjdGl2ZSBkZXZpY2UgLS0sIHRoZW4gd2Ugd291bGRuJ3QgbmVlZCB0aGF0IHBtX3J1bnRp bWVfZ2V0KCkgY2FsbCBvbgo+Pj4gPiA+ID4gcHJvYmUgYXQgYWxsLiBSYXRoZXIgd2Ugd291bGQg Zm9sbG93IHRoZSBzZXF1ZW5jZToKPj4+ID4gPiA+Cj4+PiA+ID4gPiAgICAgICAgIHBtX3J1bnRp bWVfZm9yYmlkKCkKPj4+ID4gPiA+ICAgICAgICAgcG1fcnVudGltZV9zZXRfYWN0aXZlKCkKPj4+ ID4gPiA+ICAgICAgICAgcG1fcnVudGltZV9lbmFibGUoKQo+Pj4gPiA+ID4KPj4+ID4gPiA+ICAg ICAgICAgLyogZG8geW91ciBwcm9iZSByb3V0aW5lICovCj4+PiA+ID4gPgo+Pj4gPiA+ID4gICAg ICAgICBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKQo+Pj4gPiA+ID4KPj4+ID4gPiA+IFRoZW4geW91 IHJlbW92ZSB5b3Ugd291bGQgbmVlZCB0byBjYWxsIHBtX3J1bnRpbWVfZ2V0X25vcmVzdW1lKCkg dG8KPj4+ID4gPiA+IGJhbGFuY2Ugb3V0IHRoZSBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKSB0aGVy ZS4KPj4+ID4KPj4+ID4gPiA+IChJZiB5b3UgbmVlZCB0byBrbm93IHdoeSB0aGUgcG1fcnVudGlt ZV9wdXRfbm9pZGxlKCksIHJlbWVtYmVyIHRoYXQKPj4+ID4gPiA+IHBtX3J1bnRpbWVfc2V0X2Fj dGl2ZSgpIGluY3JlbWVudHMgdGhlIHVzYWdlIGNvdW50ZXIsIHNvCj4+PiA+ID4gPiBwbV9ydW50 aW1lX3B1dF9ub2lkbGUgaXMgYmFzaWNhbGx5IGFsbG93aW5nIHBtX3J1bnRpbWUgdG8gaGFwcGVu IGFzIHNvb24KPj4+ID4gPiA+IGFzIHVzZXJzcGFjZSB3cml0ZXMgImF1dG8iIHRvIC9zeXMvLi4u Li9wb3dlci9jb250cm9sKQo+Pj4gPgo+Pj4gPiBUaGF0J3Mgbm90IGNvcnJlY3Q7IHBtX3J1bnRp bWVfc2V0X2FjdGl2ZSgpIG9ubHkgaW5jcmVtZW50cyB0aGUgdXNhZ2UKPj4+ID4gY291bnRlciBv ZiBhIHBhcmVudCAodW5kZXIgc29tZSBjaXJjdW1zdGFuY2VzKSwgc28gdW5sZXNzIHlvdSBoYXZl IGJ1cwo+Pj4gPiBjb2RlIGluY3JlbWVudGluZyB0aGUgdXNhZ2UgY291bnRlciBiZWZvcmUgcHJv YmUsIHRoZSBhYm92ZQo+Pj4gPiBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKSB3b3VsZCBhY3R1YWxs eSBpbnRyb2R1Y2UgYW4gaW1iYWxhbmNlLgo+Pj4KPj4+IE5vLCBpdCB3b3VsZG4ndC4gIEl0IGJh bGFuY2VzIHRoZSBpbmNyZW1lbnRhdGlvbiBpbiBwbV9ydW50aW1lX2ZvcmJpZCgpLgo+Pgo+PiBS aWdodCwgYnV0IGV2ZW4gaWYgeW91IHRha2UgdGhlIHdob2xlIHNlcXVlbmNlLCB3aGljaCBpbmNs dWRlZAo+PiBwbV9ydW50aW1lX2ZvcmJpZCgpLCBjb25zaWRlciB3aGF0IGhhcHBlbnMgd2hlbiBw bV9ydW50aW1lX2FsbG93KCkgaXMKPj4gbGF0ZXIgY2FsbGVkIHRocm91Z2ggc3lzZnMgKHNlZSBi ZWxvdykuCj4+Cj4+PiA+IEFuZCBub3RlIHRoYXQgdGhhdCdzIGFsc28gdGhlIGNhc2UgZXZlbiBp ZiB5b3UgbWVhbnQgdG8gc2F5IHRoYXQKPj4+ID4gKnBtX3J1bnRpbWVfZm9yYmlkKCkqIGluY3Jl bWVudHMgdGhlIHVzYWdlIGNvdW50ZXIgKHdoaWNoIGl0IGRvZXMpLgo+Pj4KPj4+IFdoeSBpcyBp dD8KPj4+Cj4+PiBTdXJlbHksIGFmdGVyCj4+Pgo+Pj4gcG1fcnVudGltZV9mb3JiaWQoZGV2KTsK Pj4+IHBtX3J1bnRpbWVfcHV0X25vaWRsZShkZXYpOwo+Pj4KPj4+IHRoZSBydW50aW1lIFBNIHVz YWdlIGNvdW50ZXIgb2YgZGV2IHdpbGwgYmUgdGhlIHNhbWUgYXMgYmVmb3JlLCB3b24ndCBpdD8K Pj4KPj4gU3VyZSwgYnV0IHRoZSBpbWJhbGFuY2UsIG9yIHJhdGhlciBpbmNvbnNpc3RlbnQgc3Rh dGUsIGhhcyBhbHJlYWR5IGJlZW4KPj4gaW50cm9kdWNlZC4KPj4KPj4gQ29uc2lkZXIgdGhlIGZv bGxvd2luZyBzZXF1ZW5jZSBvZiBldmVudHM6Cj4+Cj4+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1c2FnZSBjb3VudAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgMAo+PiBwcm9iZSgpCj4+ICAgICAgICAgcG1fcnVudGltZV9mb3JiaWQo KSAgICAgICAgICAgICAxCj4+ICAgICAgICAgcG1fcnVudGltZV9zZXRfYWN0aXZlKCkKPj4gICAg ICAgICBwbV9ydW50aW1lX2VuYWJsZSgpCj4+ICAgICAgICAgcG1fcnVudGltZV9wdXRfbm9pZGxl KCkgICAgICAgICAwCj4+Cj4+IEhlcmUgbm90aGluZyBpcyBwcmV2ZW50aW5nIHRoZSBkZXZpY2Ug ZnJvbSBydW50aW1lIHN1c3BlbmRpbmcsIGRlc3BpdGUKPj4gcnVudGltZSBQTSBiZWluZyBmb3Ji aWRkZW4uIEluIGZhY3QsIGl0IHdpbGwgdHlwaWNhbGx5IGJlIHN1c3BlbmRlZCBkdWUKPj4gdG8g dGhlIHBtX3JlcXVlc3RfaWRsZSgpIGluIGRyaXZlcl9wcm9iZV9kZXZpY2UoKS4gSWYgbGF0ZXIg d2UgaGF2ZToKPj4KPj4gZWNobyBhdXRvID4gcG93ZXIvY29udHJvbAo+PiAgICAgICAgIHBtX3J1 bnRpbWVfYWxsb3coKSAgICAgICAgICAgICAgLTEKPgo+IE9LLCB5b3UgaGF2ZSBhIHBvaW50Lgo+ Cj4gQWZ0ZXIgY2FsbGluZyBwbV9ydW50aW1lX2ZvcmJpZCgpIHRoZSBkcml2ZXIgc2hvdWxkIGFs bG93IHVzZXIgc3BhY2UKPiB0byB1bmJsb2NrIHJ1bnRpbWUgUE0gZm9yIHRoZSBkZXZpY2UgLSBv ciBjYWxsIHBtX3J1bnRpbWVfYWxsb3coKQo+IGl0c2VsZi4KClRoZSBjb25mdXNpb24gcmVnYXJk aW5nIHRoZSBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKSBhdCB0aGUgZW5kIG1heQpjb21lIGZyb20g dGhlIHNwZWNpYWwgcmVxdWlyZW1lbnQgb2YgdGhlIFBDSSBidXMgdHlwZSBhcyBwZXIgdGhlCmNv bW1lbnQgaW4gbG9jYWxfcGNpX3Byb2JlKCkuCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMg bGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBv ZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBp bmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK