From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9895C77B72 for ; Mon, 17 Apr 2023 07:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbjDQHhV (ORCPT ); Mon, 17 Apr 2023 03:37:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbjDQHhH (ORCPT ); Mon, 17 Apr 2023 03:37:07 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF7954203 for ; Mon, 17 Apr 2023 00:35:54 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id kt6so23465192ejb.0 for ; Mon, 17 Apr 2023 00:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1681716953; x=1684308953; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5XFC/9mvzx/O4+6lgw0WJn0uaQEYjzkPhtZfQPhydig=; b=HUNbhNW99JActqnQxEFBW8XSlaWGg0MbaAp51GqNl/iqZW/orFbEQDWGJd7LnYcD2G enTyvjpxSqOlLy+rHMoYWBYvMAyfQX7p0p3U2O2YlCrXy6u7plHWmfQMqziDmMLpOM7H PhewcKOa9xsP5vLUXqrKWw1hiVSVQSSG6f4okIbN7Frmr+drvDGi4L45g+XTK/wS46Zr k4z1P9XZhwDM8jNRuriP6wqOXNdPVCiKrysYQQ3vvZRCak+E7z5BkJmAwlIfNY+H9Dds h6gS7t735ef1m5k9e47nDQWr/8PjxutS/LcGnBVYGrdXYQiRuYw0OI8Z3zKwuCNx6fq8 HwAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681716953; x=1684308953; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5XFC/9mvzx/O4+6lgw0WJn0uaQEYjzkPhtZfQPhydig=; b=erbwTjkWPPKtnQq6hDWP3cSGUXX9VT/3hwSjPFMXflE9CcYn+oA9YTbduGsNGU8MKW 2GaPvGc0ZwamSgbUTEor6ogDoch2b2u775y/DVThKVaXPMNXcCwunSy3AK4yROCvr/a9 8ZaoyNEgJ9JEi8FwHfqABRZ5iW55UJf1hT7MrPCk0X5BHDFLpC6piOMYEMidtJcCnKx9 YYdShScPuGHrzFhnb/QOaUll5uXKDbo9QXSTO1EIckMXGTcOZs8hoRYN3IKmVB+8tvVN xLMDKMMh9ABaF9FBrcmWcmwQA76QHczrwJILgMqWNtmXY/xQkBIkesgrGPT+nyXmH4YH jnEQ== X-Gm-Message-State: AAQBX9ca/SLTj5QVk04n191Qe1+ljTvz3ZJSMDT02SnXaL7aTa2xRFGr X20YysXhj4SfX3N7StZZd1l6kg== X-Google-Smtp-Source: AKy350aiszsdDZQNPNMwuj0S2OGQCXnyOKHKInK77illrwKv5Zv4EoM9X2+pYLi40BANUGtxEvocIQ== X-Received: by 2002:a17:906:70d1:b0:94e:e859:8721 with SMTP id g17-20020a17090670d100b0094ee8598721mr7788806ejk.22.1681716953131; Mon, 17 Apr 2023 00:35:53 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id be5-20020a1709070a4500b0094f282fc29asm2973857ejc.207.2023.04.17.00.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 00:35:52 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 17 Apr 2023 09:35:52 +0200 Message-Id: From: "Luca Weiss" To: "Bryan O'Donoghue" , , , , , , , , , Cc: , , , , Subject: Re: [PATCH v5 00/14] Add Qualcomm PMIC TPCM support X-Mailer: aerc 0.14.0 References: <20230413113438.1577658-1-bryan.odonoghue@linaro.org> <10551f5e-4516-c0cc-0b04-73aa38f80a2c@linaro.org> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon Apr 17, 2023 at 2:30 AM CEST, Bryan O'Donoghue wrote: > On 14/04/2023 07:51, Luca Weiss wrote: > > I see "reverse" and "normal" depending on the direction the USB stick i= s > > plugged in. When unplugged but also when plugged into my PC it stays at > > "unknown". > > Right so, this is down to bad behavior on the PHY patch, which is=20 > resolved for me on sm8250 with the below. > > Basically when you unplug a device you would transition back to=20 > "TYPEC_ORIENTATION_NONE" but that would turn off the PHY, which is obs=20 > not very useful if you want to subsequently be a gadget. > > Anyway thanks for testing this - I'd missed the=20 > host->device->host->device ping-pong breakage. Hm, unfortunately no improvement with this on my side.. No USB connection pops up on the host, or USB messages regarding the USB stick on the device. Do you have an idea in which part of the code to start debugging this? Since orientation detection is working is it maybe in the phy code and not in the tcpm driver? Or does that also touch crucial stuff for USB apart from telling phy which direction to use? Regards Luca > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c=20 > b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index b9a30c087423d..edb788a71edeb 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -3372,12 +3372,13 @@ static int qmp_combo_typec_switch_set(struct=20 > typec_switch_dev *sw, > > qmp->orientation =3D orientation; > > - if (orientation =3D=3D TYPEC_ORIENTATION_NONE) { > - if (qmp->init_count) > - ret =3D qmp_combo_dp_power_off(dp_phy); > - } else { > - if (!qmp->init_count) > - ret =3D qmp_combo_dp_power_on(dp_phy); > + if (orientation !=3D TYPEC_ORIENTATION_NONE) { > + ret =3D qmp_combo_dp_power_off(dp_phy); > + if (ret) > + return ret; > + ret =3D qmp_combo_dp_power_on(dp_phy); > + if (ret) > + return ret; > } > > --- > bod