* usb: host: remove unnecessary condition check
@ 2018-11-02 14:14 Chengguang Xu
0 siblings, 0 replies; 2+ messages in thread
From: Chengguang Xu @ 2018-11-02 14:14 UTC (permalink / raw)
To: stern, gregkh; +Cc: linux-usb, Chengguang Xu
dma_pool_destroy() can handle NULL pointer correctly, so there is
no need to check NULL pointer before calling dma_pool_destroy().
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
drivers/usb/host/ohci-mem.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/ohci-mem.c b/drivers/usb/host/ohci-mem.c
index b3da3f12e5b1..3965ac0341eb 100644
--- a/drivers/usb/host/ohci-mem.c
+++ b/drivers/usb/host/ohci-mem.c
@@ -57,14 +57,10 @@ static int ohci_mem_init (struct ohci_hcd *ohci)
static void ohci_mem_cleanup (struct ohci_hcd *ohci)
{
- if (ohci->td_cache) {
- dma_pool_destroy (ohci->td_cache);
- ohci->td_cache = NULL;
- }
- if (ohci->ed_cache) {
- dma_pool_destroy (ohci->ed_cache);
- ohci->ed_cache = NULL;
- }
+ dma_pool_destroy(ohci->td_cache);
+ ohci->td_cache = NULL;
+ dma_pool_destroy(ohci->ed_cache);
+ ohci->ed_cache = NULL;
}
/*-------------------------------------------------------------------------*/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* usb: host: remove unnecessary condition check
@ 2018-11-02 14:46 Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2018-11-02 14:46 UTC (permalink / raw)
To: Chengguang Xu; +Cc: gregkh, linux-usb
On Fri, 2 Nov 2018, Chengguang Xu wrote:
> dma_pool_destroy() can handle NULL pointer correctly, so there is
> no need to check NULL pointer before calling dma_pool_destroy().
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> ---
> drivers/usb/host/ohci-mem.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-mem.c b/drivers/usb/host/ohci-mem.c
> index b3da3f12e5b1..3965ac0341eb 100644
> --- a/drivers/usb/host/ohci-mem.c
> +++ b/drivers/usb/host/ohci-mem.c
> @@ -57,14 +57,10 @@ static int ohci_mem_init (struct ohci_hcd *ohci)
>
> static void ohci_mem_cleanup (struct ohci_hcd *ohci)
> {
> - if (ohci->td_cache) {
> - dma_pool_destroy (ohci->td_cache);
> - ohci->td_cache = NULL;
> - }
> - if (ohci->ed_cache) {
> - dma_pool_destroy (ohci->ed_cache);
> - ohci->ed_cache = NULL;
> - }
> + dma_pool_destroy(ohci->td_cache);
> + ohci->td_cache = NULL;
> + dma_pool_destroy(ohci->ed_cache);
> + ohci->ed_cache = NULL;
> }
>
> /*-------------------------------------------------------------------------*/
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-02 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-02 14:46 usb: host: remove unnecessary condition check Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2018-11-02 14:14 Chengguang Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).