Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eugene Korenevsky <ekorenevsky@astralinux.ru>
Cc: linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] ehci: fix EHCI host controller initialization sequence
Date: Sat, 9 Jan 2021 09:39:32 +0100	[thread overview]
Message-ID: <X/lrxKfyGQTekKCN@kroah.com> (raw)
In-Reply-To: <20210108215504.GA27050@himera.home>

On Sat, Jan 09, 2021 at 12:55:04AM +0300, Eugene Korenevsky wrote:
> According to EHCI spec, EHCI HCD clears USBSTS.HCHalted whenever USBCMD.RS=1.
> However, it is a good practice to wait some time after setting USBCMD.RS
> (approximately 100ms) until USBSTS.HCHalted become zero.
> 
> Instead, previous version of ehci_run() wrote 1 to USBCMD.RS, issued read to
> USBCMD and waited for 5 ms.
> That worked incorrectly at least at VirtualBox's EHCI virtual HCD and caused
> accidental hangs (bugzilla #211095).
> 
> This patch fixes #211095.

What is this number from?  Can you just provide a "Link:" tag?

thanks,

greg k-h

      reply	other threads:[~2021-01-09  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 21:55 [PATCH] ehci: fix EHCI host controller initialization sequence Eugene Korenevsky
2021-01-09  8:39 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/lrxKfyGQTekKCN@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ekorenevsky@astralinux.ru \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox