Re: Conflicting PCI ID in bdc driver

Alan Cooper
2021-01-12T19:52:35Z

I just checked with the hardware engineer that designed the BDC core.
The BDC PCI driver was used with an FPGA/PCIe board for design
verification and no one should be using this driver. I'll send a patch
that will remove this driver.

Thanks
Al

On Tue, Jan 12, 2021 at 3:57 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jan 12, 2021 at 09:42:58AM +0100, Patrik Jakobsson wrote:
> > On Tue, Jan 12, 2021 at 2:06 AM Alan Cooper <alcooperx@gmail.com> wrote:
> > >
> > > This driver was written for a PCI FPGA development board used to
> > > verify the controller logic and to help with driver development before
> > > adding the logic to our SoC's. I'm not sure why the driver was pushed
> > > upstream but I'd like to remove it. I'm checking with a few other
> > > groups to make sure I'm not missing anything.
> >
> > That would solve my problem. Is removing a driver acceptable for
> > stable submission?
>
> Not really, if there are users of that driver. Why not just mark the
> config to depend on BROKEN instead?
>
> But first we need to ensure that the users of it are really all gone.
>
> > If not, it would be helpful to have a patch
> > suitable for stable that disables the driver before removal. I'm
> > somewhat tired of explaining to people how to blacklist bdc.
>
> Why not submit your driver for inclusion in the kernel tree? We can
> make sure it doesn't conflict when that happens.
>
> thanks,
>
> greg k-h