From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req
Date: Mon, 28 Dec 2020 16:01:46 +0100 [thread overview]
Message-ID: <X+nzWs3nOrcqu4F2@kroah.com> (raw)
In-Reply-To: <20201221173531.215169-4-jbrunet@baylibre.com>
On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote:
> 'struct uac_req' purpose is to link 'struct usb_request' to the
> corresponding 'struct uac_rtd_params'. However member req is never
> used. Using the context of the usb request, we can keep track of the
> corresponding 'struct uac_rtd_params' just as well, without allocating
> extra memory.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/usb/gadget/function/u_audio.c | 58 ++++++++++++---------------
> 1 file changed, 26 insertions(+), 32 deletions(-)
This patch doesn't apply, so I can't apply patches 3 or 4 of this series
:(
Can you rebase against my usb-testing branch and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2020-12-28 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 17:35 [PATCH 0/4] usb: gadget: audio fixes and clean ups Jerome Brunet
2020-12-21 17:35 ` [PATCH 1/4] usb: gadget: f_uac2: reset wMaxPacketSize Jerome Brunet
2020-12-21 17:35 ` [PATCH 2/4] usb: gadget: u_audio: factorize ssize to alsa fmt conversion Jerome Brunet
2020-12-21 17:35 ` [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req Jerome Brunet
2020-12-28 15:01 ` Greg Kroah-Hartman [this message]
2020-12-29 22:30 ` Jack Pham
2021-01-04 14:08 ` Jerome Brunet
2021-01-04 15:36 ` Greg Kroah-Hartman
2020-12-21 17:35 ` [PATCH 4/4] usb: gadget: u_audio: clean up locking Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+nzWs3nOrcqu4F2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).