From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECBEC433E0 for ; Mon, 28 Dec 2020 15:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47FBC221F0 for ; Mon, 28 Dec 2020 15:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439286AbgL1PB2 (ORCPT ); Mon, 28 Dec 2020 10:01:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:54278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392591AbgL1PBF (ORCPT ); Mon, 28 Dec 2020 10:01:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C2554208D5; Mon, 28 Dec 2020 15:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609167624; bh=TbqSh3PsttugZzWTBvvrutqtvAnSYnz4ZADL+W5fc8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lI+RFie+AwGXRUGcVCg34DyxSiywWTGmJbCDOPrDP5vUUpiIcQlsA2HCUo0m4U0kO XQBWUcYELkfwLW4h9yePXnT7ad6flrv2/PF3crl10sKdcIXKj9iieS7Hr9sPVDtyNR pai6a9dUmOmfZ6bDFJJhqtvoWVZu/RNN4Qa+GLjI= Date: Mon, 28 Dec 2020 16:01:46 +0100 From: Greg Kroah-Hartman To: Jerome Brunet Cc: Felipe Balbi , Ruslan Bilovol , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req Message-ID: References: <20201221173531.215169-1-jbrunet@baylibre.com> <20201221173531.215169-4-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201221173531.215169-4-jbrunet@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: > 'struct uac_req' purpose is to link 'struct usb_request' to the > corresponding 'struct uac_rtd_params'. However member req is never > used. Using the context of the usb request, we can keep track of the > corresponding 'struct uac_rtd_params' just as well, without allocating > extra memory. > > Signed-off-by: Jerome Brunet > --- > drivers/usb/gadget/function/u_audio.c | 58 ++++++++++++--------------- > 1 file changed, 26 insertions(+), 32 deletions(-) This patch doesn't apply, so I can't apply patches 3 or 4 of this series :( Can you rebase against my usb-testing branch and resend? thanks, greg k-h