linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 0/3] platform/chrome: cros_ec_typec: Add plug and plug altmodes
Date: Fri, 13 Nov 2020 15:13:55 +0100	[thread overview]
Message-ID: <X66Uo83dTGS2dMcx@kroah.com> (raw)
In-Reply-To: <20201112012329.1364975-1-pmalani@chromium.org>

On Wed, Nov 11, 2020 at 05:23:25PM -0800, Prashant Malani wrote:
> This patch series add plug registration support to the cros-ec-typec
> driver. It also adds support for registering alternate modes for the
> registered plug. These features utilize the API provided by the Type C
> connector class framework.
> 
> The first patch adds support to the connector class framework for the
> number_of_alternate_modes attribute (along with the relevant ABI
> documentation).
> 
> The next two patches add plug registration, and then altmode
> registration for the plugs. The latter of these two patches utilizes the
> new function for plug number_of_alternate_modes introduced in the first patch.
> 
> This series is based on top of the following branch and other patch
> series (applied in the order specified):
> - Branch: chrome-platform for-next [1], which is currently set to the
>   "Linux 5.10-rc1" tag.
> - cros-ec-typec: Patch series to register PD identity information + partner altmodes[2]
> - cros-ec-typec: Patch series to register cable[3]
> - cros-ec-typec: Patch series to add partner number_of_altmodes[4]
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git/log/?h=for-next
> [2]: https://lore.kernel.org/lkml/20201029222738.482366-1-pmalani@chromium.org/
> [3]: https://lore.kernel.org/lkml/20201106184104.939284-1-pmalani@chromium.org/
> [4]: https://lore.kernel.org/lkml/20201110061535.2163599-1-pmalani@chromium.org/

Ok, I'm confused.  This is not the first submission of this series, as
you sent out a v2 a few days before this one.

And am I supposed to suck in the chrome-platform branch into the
usb-next tree?

What should I do here, ignore these?  Merge them?

I see the USB change lost the reviewer's ack as well, why?

I'm going to delete all of these patches from my review queue now and
wait for a resend with some clarity as to what I should do with it :)

thanks,

greg k-h

  parent reply	other threads:[~2020-11-13 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12  1:23 [PATCH 0/3] platform/chrome: cros_ec_typec: Add plug and plug altmodes Prashant Malani
2020-11-12  1:23 ` [PATCH 1/3] usb: typec: Add plug num_altmodes sysfs attr Prashant Malani
2020-11-12  1:23 ` [PATCH 2/3] platform/chrome: cros_ec_typec: Register SOP' cable plug Prashant Malani
2020-11-12  1:23 ` [PATCH 3/3] platform/chrome: cros_ec_typec: Register plug altmodes Prashant Malani
2020-11-13 14:13 ` Greg KH [this message]
2020-11-13 21:38   ` [PATCH 0/3] platform/chrome: cros_ec_typec: Add plug and " Prashant Malani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X66Uo83dTGS2dMcx@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bleung@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).