Re: [PATCH] option: added support for Thales Cinterion EXS82 option port.

[Johan Hovold <johan@kernel.org>]

On Wed, Nov 25, 2020 at 11:00:26AM +0100, Giacinto Cifelli wrote:
> Hi Johan,
> 
> On Wed, Nov 25, 2020 at 10:40 AM Johan Hovold <johan@kernel.org> wrote:
> >
> > On Tue, Nov 24, 2020 at 10:41:55AM +0100, Giacinto Cifelli wrote:
> > > There is a single option port in this modem, and it is used as debug port
> > >
> > > Signed-off-by: Giacinto Cifelli <gciofono@gmail.com>
> >
> > Thanks for the update (and thanks for the review, Lars).
> >
> > Using the option driver for just a debug port seems like overkill, but
> > ok.
> >
> > Some form issues:
> >
> >  - When updating a patch always include a patch revision number in the
> >    Subject prefix (e.g. "[PATCH v2] USB: serial: option: add ...").
> >
> 
> technically this is a new patch, as I have changed the name, but I was
> reserving the v2 for the actual MV31 patch that I will send in the
> near future.

Since it's the same PID you're adding I'd still consider this a v2 even
if you changed the product name, but I see your point.

> >  - Try to follow the convention used by the subsystem for the Subject
> >    prefix (i.e. "USB: serial: option: add ...").
> 
> ok. Should I re-submit this patch?  Do you prefer v2 or v3 for a new submit?

Yes, please do send a v3.

Johan