From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C2E7C433FE for ; Fri, 4 Dec 2020 15:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06FF722B3F for ; Fri, 4 Dec 2020 15:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbgLDPQZ (ORCPT ); Fri, 4 Dec 2020 10:16:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:34430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725923AbgLDPQZ (ORCPT ); Fri, 4 Dec 2020 10:16:25 -0500 Date: Fri, 4 Dec 2020 16:17:01 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607094945; bh=/oVkJTobYG9YuE9TxjEpG3TfKjGcU4bWgUBwTFrTWD4=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=zD+/oK8LHAj7tc/WRJxlGma2XNJXNlw0moSX0OpcduUn0L9Pcke/FKiVNMMx5j8O7 GWuTqGjuwRl/7oVxOyanRKUBiZSZhWqFZ8Rrm8Dvm2fJc1YphhbcbLj20y+c3EQkhQ j3tjJ6hO+XimMPekQS8oOOn1VCEKk4Cy6pH7nJGk= From: Greg Kroah-Hartman To: Johan Hovold Cc: linux-usb@vger.kernel.org, Himadri Pandya Subject: Re: [PATCH 2/3] USB: core: drop short-transfer check from usb_control_msg_send() Message-ID: References: <20201204085110.20055-1-johan@kernel.org> <20201204085110.20055-3-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201204085110.20055-3-johan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Dec 04, 2020 at 09:51:09AM +0100, Johan Hovold wrote: > A failure to send a complete control message is always an error so > there's no need to check for short transfers in usb_control_msg_send(). > > Signed-off-by: Johan Hovold > --- > drivers/usb/core/message.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c > index a04b01247117..b08de9571f7a 100644 > --- a/drivers/usb/core/message.c > +++ b/drivers/usb/core/message.c > @@ -216,9 +216,8 @@ int usb_control_msg_send(struct usb_device *dev, __u8 endpoint, __u8 request, > > if (ret < 0) > return ret; > - if (ret == size) > - return 0; > - return -EINVAL; > + > + return 0; Ah, this came from the read call where a short read is not an error, but we wanted it to be. Nice catch. greg k-h