From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31D8C4361B for ; Wed, 9 Dec 2020 10:52:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B28223B77 for ; Wed, 9 Dec 2020 10:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729926AbgLIKwK (ORCPT ); Wed, 9 Dec 2020 05:52:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:53388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbgLIKwJ (ORCPT ); Wed, 9 Dec 2020 05:52:09 -0500 Date: Wed, 9 Dec 2020 11:52:45 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607511089; bh=gxZvIXJIju5zSeWQjr66NyC6FRe3iPh9PWurDEGzsBU=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=qTCTDkINY89L6x/MR9T0cxOnNe5pbtGM5gwpECMdf5I3pWifT9/Oj9QkTYWNc89Mg kF6PVawEdsZ4+sdMUU+FoBHnB4erupZWe39fKC7xb6aHL+rkz1/i7+wo+qss4f4jP7 xX7s/bigCKyJT7JI/y65HxopNBWKIrSUjaqo0pps= From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+8881b478dad0a7971f79@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: add interface-number sanity check to flag handling Message-ID: References: <0000000000004c471e05b60312f9@google.com> <20201209104221.13223-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209104221.13223-1-johan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Dec 09, 2020 at 11:42:21AM +0100, Johan Hovold wrote: > Add an interface-number sanity check before testing the device flags to > avoid relying on undefined behaviour when left shifting in case a device > uses an interface number greater than or equal to BITS_PER_LONG (i.e. 64 > or 32). > > Reported-by: syzbot+8881b478dad0a7971f79@syzkaller.appspotmail.com > Fixes: c3a65808f04a ("USB: serial: option: reimplement interface masking") > Cc: stable@vger.kernel.org > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman