From: Matthias Kaehlcke <mka@chromium.org>
To: mgautam@codeaurora.org
Cc: Sandeep Maheswaram <sanm@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] usb: dwc3: core: Host wake up support from system suspend
Date: Thu, 10 Dec 2020 16:04:17 -0800 [thread overview]
Message-ID: <X9K3gXAgUW/6o9dr@google.com> (raw)
In-Reply-To: <bca7bd32710a118d3583dd4e740ef3e0@codeaurora.org>
On Sat, Nov 28, 2020 at 08:01:31AM +0530, mgautam@codeaurora.org wrote:
> Hi,
>
>
> On 2020-10-28 02:07, Sandeep Maheswaram wrote:
> > Avoiding phy powerdown in host mode so that it can be woken up by
> > devices.
> > Added hs_phy_mode flag to check connection status and set phy mode
> > and configure interrupts.
> >
> > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> > ---
> > drivers/usb/dwc3/core.c | 14 +++-----------
> > drivers/usb/dwc3/core.h | 2 ++
> > 2 files changed, 5 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > index bdf0925..0e4bc1e 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1672,10 +1672,6 @@ static int dwc3_suspend_common(struct dwc3
> > *dwc, pm_message_t msg)
> > dwc3_core_exit(dwc);
> > break;
> > case DWC3_GCTL_PRTCAP_HOST:
> > - if (!PMSG_IS_AUTO(msg)) {
> > - dwc3_core_exit(dwc);
> > - break;
> > - }
>
>
> This could be a problem for platforms that don't support runtime_suspend
> and rely on dwc3_core_exit to power-down PHY.
> IMO you can continue to do dwc3_core_exit() if runtime_pm isn't enabled
> for the device.
This would imply that USB wakeup isn't supported on such platforms, right?
Could we have a flag that the dwc3-<glue> driver can set to indicate that
wakeup is enabled for this suspend cycle to omit the PHY power-down?
> >
> > /* Let controller to suspend HSPHY before PHY driver suspends */
> > if (dwc->dis_u2_susphy_quirk ||
> > @@ -1733,13 +1729,9 @@ static int dwc3_resume_common(struct dwc3 *dwc,
> > pm_message_t msg)
> > spin_unlock_irqrestore(&dwc->lock, flags);
> > break;
> > case DWC3_GCTL_PRTCAP_HOST:
> > - if (!PMSG_IS_AUTO(msg)) {
> > - ret = dwc3_core_init_for_resume(dwc);
> > - if (ret)
> > - return ret;
> > - dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_HOST);
> > - break;
> > - }
> > +
> > + dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_HOST);
> > +
> > /* Restore GUSB2PHYCFG bits that were modified in suspend */
> > reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0));
> > if (dwc->dis_u2_susphy_quirk)
> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> > index 74323b1..da63d4a3 100644
> > --- a/drivers/usb/dwc3/core.h
> > +++ b/drivers/usb/dwc3/core.h
> > @@ -1101,6 +1101,8 @@ struct dwc3 {
> >
> > bool phys_ready;
> >
> > + unsigned int hs_phy_mode;
> > +
>
> This change should instead be part of the other patch ?
> "usb: dwc3: host: Add suspend_quirk for dwc3 host"
+1
next prev parent reply other threads:[~2020-12-11 0:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 20:37 [PATCH v4 0/5] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2020-10-27 20:37 ` [PATCH v4 1/5] usb: dwc3: core: Host " Sandeep Maheswaram
2020-11-28 2:31 ` mgautam
2020-12-11 0:04 ` Matthias Kaehlcke [this message]
2020-10-27 20:38 ` [PATCH v4 2/5] usb: dwc3: host: Add suspend_quirk for dwc3 host Sandeep Maheswaram
2020-12-11 0:25 ` Matthias Kaehlcke
2020-10-27 20:38 ` [PATCH v4 3/5] usb: dwc3: qcom: Configure wakeup interrupts and set genpd active wakeup flag Sandeep Maheswaram
2020-12-11 0:47 ` Matthias Kaehlcke
2020-10-27 20:38 ` [PATCH v4 4/5] arm64: dts: qcom: sc7180: Use pdc interrupts for USB instead of GIC interrupts Sandeep Maheswaram
2021-02-25 18:15 ` Doug Anderson
2020-10-27 20:38 ` [PATCH v4 5/5] arm64: dts: qcom: sc7180: Add wakeup-source property for USB node in IDP and trogdor Sandeep Maheswaram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9K3gXAgUW/6o9dr@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).