From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@kernel.org>,
Matt Merhar <mattmerhar@protonmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Peter Geis <pgwipeout@gmail.com>, Ion Agorria <ion@agorria.com>,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/8] usb: chipidea: tegra: Rename UDC to USB
Date: Thu, 17 Dec 2020 14:36:44 +0100 [thread overview]
Message-ID: <X9te7ObUU1Fcy2ut@ulmo> (raw)
In-Reply-To: <20201217094007.19336-5-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2495 bytes --]
On Thu, Dec 17, 2020 at 12:40:03PM +0300, Dmitry Osipenko wrote:
> Rename all occurrences in the code from "udc" to "usb" and change the
> Kconfig entry in order to show that this driver supports USB modes other
> than device-only mode. The follow up patch will add host-mode support and
> it will be cleaner to perform the renaming separately, i.e. in this patch.
>
> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Ion Agorria <ion@agorria.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/usb/chipidea/Kconfig | 2 +-
> drivers/usb/chipidea/ci_hdrc_tegra.c | 78 ++++++++++++++--------------
> 2 files changed, 40 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> index 8bafcfc6080d..8685ead6ccc7 100644
> --- a/drivers/usb/chipidea/Kconfig
> +++ b/drivers/usb/chipidea/Kconfig
> @@ -53,7 +53,7 @@ config USB_CHIPIDEA_GENERIC
> default USB_CHIPIDEA
>
> config USB_CHIPIDEA_TEGRA
> - tristate "Enable Tegra UDC glue driver" if EMBEDDED
> + tristate "Enable Tegra USB glue driver" if EMBEDDED
> depends on OF
> depends on USB_CHIPIDEA_UDC
> default USB_CHIPIDEA
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> index 10eaaba2a3f0..d8efa80aa1c2 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -12,7 +12,7 @@
>
> #include "ci.h"
>
> -struct tegra_udc {
> +struct tegra_usb {
> struct ci_hdrc_platform_data data;
> struct platform_device *dev;
>
> @@ -20,15 +20,15 @@ struct tegra_udc {
> struct clk *clk;
> };
>
> -struct tegra_udc_soc_info {
> +struct tegra_usb_soc_info {
> unsigned long flags;
> };
>
> -static const struct tegra_udc_soc_info tegra_udc_soc_info = {
> +static const struct tegra_usb_soc_info tegra_udc_soc_info = {
> .flags = CI_HDRC_REQUIRES_ALIGNED_DMA,
> };
>
> -static const struct of_device_id tegra_udc_of_match[] = {
> +static const struct of_device_id tegra_usb_of_match[] = {
> {
> .compatible = "nvidia,tegra20-udc",
Do we perhaps also want to add a new tegra20-usb compatible string here
and deprecate the old one since this now no longer properly describes
the device.
In either case, this looks fine:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-17 13:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 9:39 [PATCH v2 0/8] Support Runtime PM and host mode by Tegra ChipIdea USB driver Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 1/8] usb: phy: tegra: Add delay after power up Dmitry Osipenko
2020-12-17 13:25 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 2/8] usb: phy: tegra: Support waking up from a low power mode Dmitry Osipenko
2020-12-17 13:33 ` Thierry Reding
2020-12-17 13:47 ` Dmitry Osipenko
2020-12-17 15:04 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 3/8] usb: chipidea: tegra: Remove MODULE_ALIAS Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 4/8] usb: chipidea: tegra: Rename UDC to USB Dmitry Osipenko
2020-12-17 13:36 ` Thierry Reding [this message]
2020-12-17 14:00 ` Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 5/8] usb: chipidea: tegra: Support host mode Dmitry Osipenko
2020-12-17 13:40 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 6/8] usb: chipidea: tegra: Support runtime PM Dmitry Osipenko
2020-12-17 13:41 ` Thierry Reding
2020-12-17 13:45 ` Dmitry Osipenko
2020-12-17 15:02 ` Thierry Reding
2020-12-17 19:51 ` Dmitry Osipenko
2020-12-17 15:02 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 7/8] usb: host: ehci-tegra: Remove the driver Dmitry Osipenko
2020-12-17 13:42 ` Thierry Reding
2020-12-17 15:50 ` Alan Stern
2020-12-17 19:43 ` Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 8/8] ARM: tegra_defconfig: Enable USB_CHIPIDEA and remove USB_EHCI_TEGRA Dmitry Osipenko
2020-12-17 13:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9te7ObUU1Fcy2ut@ulmo \
--to=thierry.reding@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=balbi@kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ion@agorria.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).