From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Robin van der Gracht <robin@protonic.nl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Raul E Rangel <rrangel@chromium.org>,
Wolfram Sang <wsa@kernel.org>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-usb@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/3] auxdisplay: ht16k33: Make use of device_get_match_data()
Date: Thu, 23 Feb 2023 13:53:15 +0200 [thread overview]
Message-ID: <Y/dTqynpTWn86wUy@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdXbYapqG1eirbRoxS9akue+URKOV338efMp1c0CbwUEKg@mail.gmail.com>
On Thu, Feb 23, 2023 at 10:55:15AM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 22, 2023 at 8:21 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Feb 22, 2023 at 07:46:25PM +0100, Krzysztof Kozlowski wrote:
...
> > I.o.w. the part after comma in the compatible strings of the I²C devices must
> > be unique globally to make that enumeration disambiguous.
>
> Which is not unique to this driver?
> I bet you can find other compatible values that become non-unique
> after stripping the manufacturer.
Yes, exactly my point.
So this all schema is error prone. Hence I would not rely on it at all.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-23 11:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 13:33 [PATCH v1 0/3] i2c: stop using i2c_of_match_device() Andy Shevchenko
2023-02-21 13:33 ` [PATCH v1 1/3] usb: typec: stusb160x: Make use of device_get_match_data() Andy Shevchenko
2023-02-21 13:53 ` Heikki Krogerus
2023-02-21 13:33 ` [PATCH v1 2/3] auxdisplay: ht16k33: " Andy Shevchenko
2023-02-21 13:40 ` Andy Shevchenko
2023-02-21 16:10 ` Robin van der Gracht
2023-02-21 17:48 ` Andy Shevchenko
2023-02-22 16:46 ` Robin van der Gracht
2023-02-22 17:01 ` Andy Shevchenko
2023-02-22 17:20 ` Andy Shevchenko
2023-02-22 18:46 ` Krzysztof Kozlowski
2023-02-22 19:11 ` Andy Shevchenko
2023-02-23 9:55 ` Geert Uytterhoeven
2023-02-23 11:53 ` Andy Shevchenko [this message]
2023-02-23 8:19 ` Robin van der Gracht
2023-02-21 13:33 ` [PATCH v1 3/3] i2c: Unexport i2c_of_match_device() Andy Shevchenko
2023-02-23 13:50 ` [PATCH v1 0/3] i2c: stop using i2c_of_match_device() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/dTqynpTWn86wUy@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
--cc=rrangel@chromium.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox