linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Yuiko Oshino <yuiko.oshino@microchip.com>
Cc: enguerrand.de-ribaucourt@savoirfairelinux.com,
	woojung.huh@microchip.com, hkallweit1@gmail.com,
	netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
	UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
	edumazet@google.com, linux-usb@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver
Date: Thu, 16 Feb 2023 16:08:47 +0100	[thread overview]
Message-ID: <Y+5G/yc7UB+ahylb@lunn.ch> (raw)
In-Reply-To: <b317787e1e55f9c59c55a3cf5f9f02d477dd5a59.1676490952.git.yuiko.oshino@microchip.com>

On Thu, Feb 16, 2023 at 07:20:53AM -0700, Yuiko Oshino wrote:
> Move the LAN7800 internal phy (phy ID  0x0007c132) specific register accesses to the phy driver (microchip.c).
> 
> Fixes: 14437e3fa284f465dbbc8611fd4331ca8d60e986 ("lan78xx: workaround of forced 100 Full/Half duplex mode error")

I would not say this is a fix which needs putting into stable. The
architecture is wrong to do it in the MAC driver, but i don't think it
causes real issues?

So please submit this to net-next, not net.

   Andrew

  reply	other threads:[~2023-02-16 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 14:20 [PATCH net 0/2] net:usb:lan78xx: move LAN7800 internal phy register accesses to the phy driver Yuiko Oshino
2023-02-16 14:20 ` [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver Yuiko Oshino
2023-02-16 15:08   ` Andrew Lunn [this message]
2023-02-16 15:20     ` Yuiko.Oshino
2023-02-16 16:56       ` Andrew Lunn
2023-02-16 18:30         ` Yuiko.Oshino
2023-02-16 14:20 ` [PATCH net 2/2] net:phy:microchip: " Yuiko Oshino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+5G/yc7UB+ahylb@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=enguerrand.de-ribaucourt@savoirfairelinux.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    --cc=yuiko.oshino@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).