Re: [PATCH] thunderbolt: Disable CLx state for AMD Yellow Carp and Pink Sardine

[Mika Westerberg <mika.westerberg@linux.intel.com>]

On Fri, Feb 10, 2023 at 08:16:48PM +0530, Sanjay R Mehta wrote:
> 
> 
> On 2/10/2023 7:47 PM, Mika Westerberg wrote:
> > On Fri, Feb 10, 2023 at 07:32:13PM +0530, Sanjay R Mehta wrote:
> >>
> >>
> >> On 2/10/2023 7:25 PM, Mika Westerberg wrote:
> >>> Hi,
> >>>
> >>> On Fri, Feb 10, 2023 at 07:32:23AM -0600, Sanjay R Mehta wrote:
> >>>> From: Sanjay R Mehta <sanju.mehta@amd.com>
> >>>>
> >>>> AMD Yellow Carp and Pink Sardine don't support CLx state,
> >>>> hence disabling it.
> >>>
> >>> The lane adapters are supposed to announce whether CL-states are
> >>> supported or not. Is that not the case with the AMD hardware?
> >>
> >> Yes Mika. it doesn't work for AMD hardware.
> > 
> > :-(
> > 
> > Okay can you then add a quirk for this to quirks.c?
> 
> Did you meant like below, is this fine?

I mean add the affected routers to quirks.c that then sets:

	sw->quirks |= QUIRK_NO_CLX;

and check this in tb_switch_clx_is_supported(), if set return false or
something like that.

I know we have bunch of Intel specific quirks littered around the
driver but let's not add more. We should move these too into quirks.c at
some point.