Re: [PATCH v3 1/2] usb: typec: pd: Remove usb_suspend_supported sysfs from sink PDO

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Tue, Feb 14, 2023 at 05:15:42PM +0530, Saranya Gopal wrote:
> As per USB PD specification, 28th bit of fixed supply sink PDO
> represents "higher capability" attribute and not "usb suspend
> supported" attribute. So, this patch removes the usb_suspend_supported
> attribute from sink PDO.
> 
> Fixes: 662a60102c12 ("usb: typec: Separate USB Power Delivery from USB Type-C")
> Reported-by: Rajaram Regupathy <rajaram.regupathy@intel.com>
> Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> Changes from v2:
>  - Patch was split into 2
>  - This patch only removes usb_suspend_supported attribute for sink PDOs
> 
>  drivers/usb/typec/pd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/pd.c b/drivers/usb/typec/pd.c
> index dc72005d68db..b5ab26422c34 100644
> --- a/drivers/usb/typec/pd.c
> +++ b/drivers/usb/typec/pd.c
> @@ -161,7 +161,6 @@ static struct device_type source_fixed_supply_type = {
>  
>  static struct attribute *sink_fixed_supply_attrs[] = {
>  	&dev_attr_dual_role_power.attr,
> -	&dev_attr_usb_suspend_supported.attr,
>  	&dev_attr_unconstrained_power.attr,
>  	&dev_attr_usb_communication_capable.attr,
>  	&dev_attr_dual_role_data.attr,
> -- 
> 2.25.1

-- 
heikki