From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
balbi@kernel.org, laurent.pinchart@ideasonboard.com,
kernel@pengutronix.de
Subject: Re: [PATCH] usb: gadget: uvc: default the ctrl request interface offsets
Date: Mon, 10 Oct 2022 22:21:35 +0200 [thread overview]
Message-ID: <Y0R+z9gtW1+Yd71d@kroah.com> (raw)
In-Reply-To: <20221010182028.402155-1-m.grzeschik@pengutronix.de>
On Mon, Oct 10, 2022 at 08:20:28PM +0200, Michael Grzeschik wrote:
> For the userspace it is needed to distinguish between requests for the
> control or streaming interface. The userspace would have to parse the
> configfs to know which interface index it has to compare the ctrl
> requests against. Since the interface numbers are not fixed, e.g. for
> composite gadgets, the interface offset depends on the setup.
>
> The kernel has this information when handing over the ctrl request to
> the userspace. This patch removes the offset from the interface numbers
> and expose the default interface defines in the uapi g_uvc.h.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> drivers/usb/gadget/function/f_uvc.c | 16 +++++++++++++---
> include/uapi/linux/usb/g_uvc.h | 3 +++
> 2 files changed, 16 insertions(+), 3 deletions(-)
This is a v2, what changed from v1?
thanks,
greg k-h
next prev parent reply other threads:[~2022-10-10 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 18:20 [PATCH] usb: gadget: uvc: default the ctrl request interface offsets Michael Grzeschik
2022-10-10 20:21 ` Greg KH [this message]
2022-10-10 21:03 ` Michael Grzeschik
2022-10-11 6:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0R+z9gtW1+Yd71d@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).