From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E67C43217 for ; Tue, 11 Oct 2022 05:39:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229538AbiJKFj0 (ORCPT ); Tue, 11 Oct 2022 01:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbiJKFjZ (ORCPT ); Tue, 11 Oct 2022 01:39:25 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 599437B1F7; Mon, 10 Oct 2022 22:39:24 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 87E8880FE; Tue, 11 Oct 2022 05:30:36 +0000 (UTC) Date: Tue, 11 Oct 2022 08:39:22 +0300 From: Tony Lindgren To: Sicelo Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, maemo-leste@lists.dyne.org, Felipe Balbi , phone-devel@vger.kernel.org, Bin Liu , Rob Herring , "H. Nikolaus Schaller" Subject: Re: [maemo-leste] USB PHY Initialization Fails on Nokia N900 Since 5.19 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Adding Rob and HNS to Cc too for commit cf081d009c44 ("usb: musb: Set the DT node on the child device"). * Sicelo [221010 09:00]: > I have tried to bisect, but due to inexperience and lack of proper > tooling (e.g. no serial console), I have not been able to pinpoint the > cause of the error so far. However, on linux 6.0 with cf081d009c447647 > reverted, there is a more detailed trace in dmesg - the same trace > appeared in other kernel versions while bisecting: To me it seems that we now somehow have a probe issue for musb depending on how it gets probed depending on the following line: device_set_of_node_from_dev(&musb->dev, &pdev->dev); I think commit 239071064732 ("partially Revert "usb: musb: Set the DT node on the child device"") fixed the issue for omap3 that still uses hwmod by removing the device_set_of_node_from_dev(). However, it somehow broke SoCs using ti-sysc like omap4. My guess is commit 239071064732 will fix the issue for you? I'm not sure what the proper fix here might be to have both working though :) FYI, I have a pending patch set to convert omap3 also to probe with ti-sysc for musb, but seems like there's some other issue here that should be fixed first. Regards, Tony