From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [bug report] usb: dwc3: drd: Defer probe if extcon device is not found
Date: Fri, 14 Oct 2022 13:13:30 +0300 [thread overview]
Message-ID: <Y0k2SoIqXziSyy46@smile.fi.intel.com> (raw)
In-Reply-To: <Y0ktkKfTgISmLogV@kili>
On Fri, Oct 14, 2022 at 12:36:16PM +0300, Dan Carpenter wrote:
> Hello Andy Shevchenko,
>
> The patch 98bba546e82d: "usb: dwc3: drd: Defer probe if extcon device
> is not found" from Feb 18, 2019, leads to the following Smatch static
> checker warning:
>
> drivers/usb/dwc3/drd.c:460 dwc3_get_extcon()
> warn: 'edev' is an error pointer or valid
The culprit is wrong, but the rest seems correct.
Thank you.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-14 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 9:36 [bug report] usb: dwc3: drd: Defer probe if extcon device is not found Dan Carpenter
2022-10-14 10:13 ` Andy Shevchenko [this message]
2022-10-18 13:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0k2SoIqXziSyy46@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).