linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Albert Wang <albertccwang@google.com>
Cc: mathias.nyman@intel.com, badhri@google.com, howardyen@google.com,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Greg Kroah-Harktman <gregkh@google.com>
Subject: Re: [PATCH 1/3] usb: host: add xhci hooks for USB offload
Date: Thu, 27 Oct 2022 08:20:22 +0200	[thread overview]
Message-ID: <Y1ojJo635jkKNogx@kroah.com> (raw)
In-Reply-To: <20221027004050.4192111-2-albertccwang@google.com>

On Thu, Oct 27, 2022 at 08:40:48AM +0800, Albert Wang wrote:
> From: Howard Yen <howardyen@google.com>
> 
> This change is to provide USB offload function which allows to offload some
> xHCI operations on co-processor. This is especially designed for USB audio
> usecase. The co-processor is able to manipulate some USB structures in his
> own memory, like SRAM.
> 
> There are several offload_ops introduced by this patch:
> 
> struct xhci_offload_ops - function callbacks for offlad specific operations
> {
> 	@offload_init:
> 		- called for vendor init process during xhci-plat-hcd
> 		  probe.
> 	@offload_cleanup:
> 		- called for vendor cleanup process during xhci-plat-hcd
> 		  remove.
> 	@is_usb_offload_enabled:
> 		- called to check if usb offload enabled.
> 	@alloc_dcbaa:
> 		- called when allocating vendor specific dcbaa during
> 		  memory initializtion.
> 	@free_dcbaa:
> 		- called to free vendor specific dcbaa when cleanup the
> 		  memory.
> 	@alloc_transfer_ring:
> 		- called when vendor specific transfer ring allocation is required
> 	@free_transfer_ring:
> 		- called to free vendor specific transfer ring
> 	@usb_offload_skip_urb:
> 		- called to check if need to skip urb enqueue
> }
> 
> The xhci hooks with prefix "xhci_vendor_" on the ops in xhci_offload_ops.
> For example, offload_init ops will be invoked by xhci_vendor_offload_init()
> hook,is_usb_offload_enabled ops will be invoked by
> xhci_vendor_is_usb_offload_enabled(), and so on.
> 
> Signed-off-by: Howard Yen <howardyen@google.com>
> Link: https://lore.kernel.org/r/20210119101044.1637023-1-howardyen@google.com
> Signed-off-by: Greg Kroah-Harktman <gregkh@google.com>

Sorry, but no, I did NOT sign of on this patch for submission here.

And if you read the link above, you will see that I explicitly rejected
this commit for inclusion.

What changed from this previous series?  Is any of the issues raised
there now resolved?  If so, how?  If not, why not?

thanks,

greg k-h

  reply	other threads:[~2022-10-27  6:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  0:40 [PATCH 0/3] add xhci hooks for USB offload Albert Wang
2022-10-27  0:40 ` [PATCH 1/3] usb: host: " Albert Wang
2022-10-27  6:20   ` Greg KH [this message]
2022-10-27  0:40 ` [PATCH 2/3] usb: xhci-plat: add xhci_plat_priv_overwrite Albert Wang
2022-10-27  6:23   ` Greg KH
2022-11-03 14:12     ` Albert Wang
2022-10-27  0:40 ` [PATCH 3/3] usb: host: add the xhci offload hooks implementations Albert Wang
2022-10-27  6:22   ` Greg KH
2022-10-27  6:18 ` [PATCH 0/3] add xhci hooks for USB offload Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1ojJo635jkKNogx@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=albertccwang@google.com \
    --cc=badhri@google.com \
    --cc=gregkh@google.com \
    --cc=howardyen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).