From: Greg KH <gregkh@linuxfoundation.org>
To: Albert Wang <albertccwang@google.com>
Cc: mathias.nyman@intel.com, badhri@google.com, howardyen@google.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: host: add the xhci offload hooks implementations
Date: Thu, 27 Oct 2022 08:22:49 +0200 [thread overview]
Message-ID: <Y1ojue+vPJyyK9Uc@kroah.com> (raw)
In-Reply-To: <20221027004050.4192111-4-albertccwang@google.com>
On Thu, Oct 27, 2022 at 08:40:50AM +0800, Albert Wang wrote:
> Add the offload hooks implementations and call to co-processor for
> offload operations.
You forgot to submit the user for all of these hooks at the same time.
For obvious reasons (and this was raised every time this patch series
has been submitted), we can not take hooks or apis that do not have a
real user of them at the same time.
And you don't want us to do that either, right? How would you maintain
a chunk of code that has calls to other code that is not even in the
same repo and that you can never seee? Would you be able to do that?
Again, please read the comments that came up when this was submitted
last time, and work to resolve them before submitting this series again.
I do not see any changes here from the last submission. If that is
incorrect, then you need to document what changed, as our kernel
documentation asks you to do.
thanks,
greg k-h
next prev parent reply other threads:[~2022-10-27 6:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 0:40 [PATCH 0/3] add xhci hooks for USB offload Albert Wang
2022-10-27 0:40 ` [PATCH 1/3] usb: host: " Albert Wang
2022-10-27 6:20 ` Greg KH
2022-10-27 0:40 ` [PATCH 2/3] usb: xhci-plat: add xhci_plat_priv_overwrite Albert Wang
2022-10-27 6:23 ` Greg KH
2022-11-03 14:12 ` Albert Wang
2022-10-27 0:40 ` [PATCH 3/3] usb: host: add the xhci offload hooks implementations Albert Wang
2022-10-27 6:22 ` Greg KH [this message]
2022-10-27 6:18 ` [PATCH 0/3] add xhci hooks for USB offload Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1ojue+vPJyyK9Uc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=albertccwang@google.com \
--cc=badhri@google.com \
--cc=howardyen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).