From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E69EFA3741 for ; Sat, 29 Oct 2022 01:44:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbiJ2Boi (ORCPT ); Fri, 28 Oct 2022 21:44:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbiJ2Boh (ORCPT ); Fri, 28 Oct 2022 21:44:37 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 233F021B0 for ; Fri, 28 Oct 2022 18:44:30 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id h2so6278521pgp.4 for ; Fri, 28 Oct 2022 18:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TOilMmjpabMBP6lbtmoPdAvGW0C2EX+ahZ9p24ZQQlI=; b=lmLpsUA1Cvy+01SKRuVljHn8ljwtr5HWbkQY5Dsldo2NPanmhoJEOUYixPgpxspCkH smsV2XBCrNqBdjs9No4ZFj58GewppuFM7R6Or9WofJUS/bMSrZK2vPQ6myjTljbIcUGM FtbAb0BLnwe1LWbqwfySZyUfLDGdmh39E5MoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TOilMmjpabMBP6lbtmoPdAvGW0C2EX+ahZ9p24ZQQlI=; b=qnJ+DsU5OZhpeH53jMpY8dRAnSGBJvHTgEZHOLS2qkzmxKpDSHJ6Dq85ueZwdqvK7O kqk1MTrKOQ7svT/pZ/oQrsZMQMYGHY5BRoHOYzgMF+BuKWqR8YrzD4neK+GvYaKFNWRI rihoYOQx/Ax0guNn8wYQs1f/TgY7CXG5I4lyotd4RHBRD85uHtVeIYDDgwqsAm1UsT18 yE3mrPt4Cr1wvPs7UYsiogoP2v3zsBKn1fgpGkpZ8dg2eXjBwhXt409g4xQDFCgwZiuP m2hLnsdobRjNg62QcL2ipvfT9Ng/uO6kA8JUssopI3PAYuTyubnlw5Jt+7WGUAotjhld K/VQ== X-Gm-Message-State: ACrzQf2LmI7etNE1h8S6IxhSO249Bbhn4XTPFhQM79Gr7MxKDBUVsCjb IojU/zIRITf2CuFFo6a7rKO6iw== X-Google-Smtp-Source: AMsMyM7GrMDVnCAK61/LBqnfafk4zDoWcDpN6Y9d2KXnr9xk9xrXRf+n16gCEpTSzqs54S73/5h81g== X-Received: by 2002:a63:581e:0:b0:43c:29a0:6390 with SMTP id m30-20020a63581e000000b0043c29a06390mr2156483pgb.552.1667007869602; Fri, 28 Oct 2022 18:44:29 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:65f9:c180:249c:190f]) by smtp.gmail.com with ESMTPSA id z190-20020a6365c7000000b0043014f9a4c9sm85791pgb.93.2022.10.28.18.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 18:44:29 -0700 (PDT) Date: Fri, 28 Oct 2022 18:44:26 -0700 From: Brian Norris To: Alan Stern Cc: Greg Kroah-Hartman , Mathias Nyman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/2] usb: ehci-pci: Set PROBE_PREFER_ASYNCHRONOUS Message-ID: References: <20221028141821.1.I9a5353f81d1509f85f3a04f0cdc9099f6fe60811@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Oct 28, 2022 at 09:13:14PM -0400, Alan Stern wrote: > However, I'm curious to know why this patch makes ehci-pci use > PROBE_PREFER_ASYNCHRONOUS even when CONFIG_PM isn't set, whereas the 2/2 > patch makes xhci-pci use PROBE_PREFER_ASYNCHRONOUS only when CONFIG_PM > is set. That's definitely a bug in patch 2. This has nothing (or, little; probe order can technically affect the PM suspend/resume order) to do with CONFIG_PM, except that the .pm hooks tend to sit nearby, and repeated driver patching makes the author's eyes glaze over sometimes... Thanks. v2 coming. Brian