From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Stefan Agner <stefan@agner.ch>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 2/2] of: export of_device_add()
Date: Thu, 3 Nov 2022 15:42:58 +0100 [thread overview]
Message-ID: <Y2PTckTXbBysjrUm@hovoldconsulting.com> (raw)
In-Reply-To: <Y2PSzCEr2c2g9ZJp@kroah.com>
On Thu, Nov 03, 2022 at 11:40:12PM +0900, Greg Kroah-Hartman wrote:
> On Thu, Nov 03, 2022 at 03:12:33PM +0100, Marek Szyprowski wrote:
> > Export of_device_add() function to let DWC3 driver (Exynos variant) to
> > instantiate DWC3 core device from the respective child OF-node with a
> > custom, addtional properties added.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > drivers/of/device.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > index 8cefe5a7d04e..bc60c9b6863c 100644
> > --- a/drivers/of/device.c
> > +++ b/drivers/of/device.c
> > @@ -52,6 +52,7 @@ int of_device_add(struct platform_device *ofdev)
> >
> > return device_add(&ofdev->dev);
> > }
> > +EXPORT_SYMBOL(of_device_add);
>
> I do not see any user of this symbol after this patch (no 3/2?)
>
> So why is it needed? No driver should ever be calling this function
> directly.
It was used by 1/2 so this would have broken bisectability.
Johan
next prev parent reply other threads:[~2022-11-03 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221103141239eucas1p29dac7ffb7202852c18e48c48c068a90f@eucas1p2.samsung.com>
2022-11-03 14:12 ` [PATCH 1/2] usb: dwc3: exynos: force PHY control from XHCI HCD Marek Szyprowski
[not found] ` <CGME20221103141239eucas1p167f44609369010a20293d5123214426d@eucas1p1.samsung.com>
2022-11-03 14:12 ` [PATCH 2/2] of: export of_device_add() Marek Szyprowski
2022-11-03 14:40 ` Greg Kroah-Hartman
2022-11-03 14:42 ` Johan Hovold [this message]
2022-11-03 14:41 ` [PATCH 1/2] usb: dwc3: exynos: force PHY control from XHCI HCD Greg Kroah-Hartman
2022-11-03 14:41 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2PTckTXbBysjrUm@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).