From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF34C433FE for ; Fri, 4 Nov 2022 14:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbiKDOmV (ORCPT ); Fri, 4 Nov 2022 10:42:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbiKDOlo (ORCPT ); Fri, 4 Nov 2022 10:41:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACE8430548 for ; Fri, 4 Nov 2022 07:40:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 68147B82E33 for ; Fri, 4 Nov 2022 14:40:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2CF0C4347C; Fri, 4 Nov 2022 14:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667572842; bh=RDDsPkpNZRpYKK4ozK+ep3DrVYywS+Bc1tJ+1VpuDHA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nM+yYPv5yXHM3EKyG1ki+xl3tjvmR7Pf5Ehw/0i0d0hMTjvwhlAe+HvNHzw2K1jGU 7FZZZgG6zDKaljWV6360kJEHmkwGbTaVPTkbmkqSrfxLD3BfJ/p2hm/9kxHGOBfA4p +UQdtDv+2hxmotX0a8UlI4NbxsADfbkkHifSxd70= Date: Fri, 4 Nov 2022 15:40:38 +0100 From: Greg KH To: Albert Zhou Cc: linux-usb@vger.kernel.org, nic_swsd@realtek.com Subject: Re: [PATCH net-next 2/2] Update R8152 module to v2 obtained from the Realtek website, included in a comment in r8152.c. The only other modification to r8152.c is amending netif_napi_add, see comment for explanation. Message-ID: References: <20221104132526.64530-1-albert.zhou.50@gmail.com> <20221104132526.64530-3-albert.zhou.50@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221104132526.64530-3-albert.zhou.50@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Nov 05, 2022 at 12:25:26AM +1100, Albert Zhou wrote: > --- > drivers/net/usb/r8152.c | 17938 +++++++++++++++++++----- > drivers/net/usb/r8152_compatibility.h | 658 + > 2 files changed, 15130 insertions(+), 3466 deletions(-) > create mode 100644 drivers/net/usb/r8152_compatibility.h > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool. - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot