Re: [PATCH v4 3/3] USB: serial: option: add u-blox LARA-L6 modem

[Johan Hovold <johan@kernel.org>]

On Tue, Nov 15, 2022 at 11:18:17AM +0100, Johan Hovold wrote:
> On Tue, Nov 08, 2022 at 05:30:01PM +0100, Davide Tronchin wrote:
> > Add LARA-L6 PIDs for three different USB compositions.
> > 
> > LARA-L6 module can be configured (by AT interface) in three different
> > USB modes:
> > * Default mode (Vendor ID: 0x1546 Product ID: 0x1341) with 4 serial
> > interfaces
> > * RmNet mode (Vendor ID: 0x1546 Product ID: 0x1342) with 4 serial
> > interfaces and 1 RmNet virtual network interface
> > * CDC-ECM mode (Vendor ID: 0x1546 Product ID: 0x1343) with 4 serial
> > interface and 1 CDC-ECM virtual network interface
> > 
> > In default mode LARA-L6 exposes the following interfaces:
> > If 0: Diagnostic
> > If 1: AT parser
> > If 2: AT parser
> > If 3: AT parser/alternative functions
 
> > @@ -1125,6 +1130,13 @@ static const struct usb_device_id option_ids[] = {
> >  	  .driver_info = RSVD(1) | RSVD(3) },
> >  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x908b), /* u-blox LARA-R6 00B */
> >  	  .driver_info = RSVD(4) },
> > +	/* u-blox products using u-blox vendor ID */
> > +	{ USB_DEVICE(UBLOX_VENDOR_ID, UBLOX_PRODUCT_LARA_L6),
> > +	  .driver_info = RSVD(4) },
> 
> Why are you reserving interface 4 here? This should be removed or
> explained in the commit message.

Apparently Lars already pointed this out, but again you ignored review
feedback without any comment and sent a v5.

Mistakes happen, but this is starting to look like more than that.

> > +	{ USB_DEVICE(UBLOX_VENDOR_ID, UBLOX_PRODUCT_LARA_L6_RMNET),
> > +	  .driver_info = RSVD(4) },
> > +	{ USB_DEVICE(UBLOX_VENDOR_ID, UBLOX_PRODUCT_LARA_L6_ECM),
> > +	  .driver_info = RSVD(4) },
> >  	/* Quectel products using Quectel vendor ID */
> >  	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21, 0xff, 0xff, 0xff),
> >  	  .driver_info = NUMEP2 },
 
Johan