* [PATCH] usb: ehci-orion: use devm_platform_get_and_ioremap_resource()
@ 2022-11-11 6:33 ye.xingchen
2022-11-15 10:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2022-11-11 6:33 UTC (permalink / raw)
To: stern; +Cc: gregkh, linux-usb, linux-kernel, chi.minghao
From: Minghao Chi <chi.minghao@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/usb/host/ehci-orion.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
index a3454a3ea4e0..d0970caf3c3a 100644
--- a/drivers/usb/host/ehci-orion.c
+++ b/drivers/usb/host/ehci-orion.c
@@ -234,8 +234,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
if (err)
goto err;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- regs = devm_ioremap_resource(&pdev->dev, res);
+ regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(regs)) {
err = PTR_ERR(regs);
goto err;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: ehci-orion: use devm_platform_get_and_ioremap_resource()
2022-11-11 6:33 [PATCH] usb: ehci-orion: use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2022-11-15 10:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-11-15 10:33 UTC (permalink / raw)
To: ye.xingchen; +Cc: stern, linux-usb, linux-kernel, chi.minghao
On Fri, Nov 11, 2022 at 02:33:14PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
You did not follow the rules when using a tool to find and fix problems,
please read the documentation for how to do so correctly.
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Your email is showing up as being invalid, and spoofed, please work with
your domain to properly handle verified email otherwise it will not be
able to be accepted.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-15 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-11 6:33 [PATCH] usb: ehci-orion: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-15 10:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).