linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: "Angel Iglesias" <ang.iglesiasg@gmail.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Wolfram Sang" <wsa@kernel.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-i2c@vger.kernel.org, kernel@pengutronix.de,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 579/606] usb: typec: tcpm/fusb302: Convert to i2c's .probe_new()
Date: Mon, 21 Nov 2022 11:06:52 +0200	[thread overview]
Message-ID: <Y3s/rFMTr8JCMuyd@kuha.fi.intel.com> (raw)
In-Reply-To: <20221118224540.619276-580-uwe@kleine-koenig.org>

On Fri, Nov 18, 2022 at 11:45:13PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/fusb302.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 721b2a548084..1ffce00d94b4 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1677,8 +1677,7 @@ static struct fwnode_handle *fusb302_fwnode_get(struct device *dev)
>  	return fwnode;
>  }
>  
> -static int fusb302_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int fusb302_probe(struct i2c_client *client)
>  {
>  	struct fusb302_chip *chip;
>  	struct i2c_adapter *adapter = client->adapter;
> @@ -1837,7 +1836,7 @@ static struct i2c_driver fusb302_driver = {
>  		   .pm = &fusb302_pm_ops,
>  		   .of_match_table = of_match_ptr(fusb302_dt_match),
>  		   },
> -	.probe = fusb302_probe,
> +	.probe_new = fusb302_probe,
>  	.remove = fusb302_remove,
>  	.id_table = fusb302_i2c_device_id,
>  };

thanks,

-- 
heikki

  parent reply	other threads:[~2022-11-21  9:07 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 572/606] usb: usb251xb: Convert to i2c's .probe_new() Uwe Kleine-König
2022-11-20 19:49   ` Richard Leitner
2022-11-18 22:45 ` [PATCH 573/606] usb: misc: usb3503: " Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 574/606] usb: usb4604: " Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 575/606] usb: isp1301-omap: " Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 576/606] usb: phy: isp1301: " Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 577/606] usb: typec: anx7411: " Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 578/606] usb: typec: hd3ss3220: " Uwe Kleine-König
2022-11-21  9:06   ` Heikki Krogerus
2022-11-18 22:45 ` [PATCH 579/606] usb: typec: tcpm/fusb302: " Uwe Kleine-König
2022-11-18 22:56   ` Guenter Roeck
2022-11-21  9:06   ` Heikki Krogerus [this message]
2022-11-18 22:45 ` [PATCH 580/606] usb: typec: tcpm/tcpci: " Uwe Kleine-König
2022-11-18 22:57   ` Guenter Roeck
2022-11-21  9:07   ` Heikki Krogerus
2022-11-18 22:45 ` [PATCH 581/606] usb: typec: tcpm/tcpci_maxim: " Uwe Kleine-König
2022-11-18 22:57   ` Guenter Roeck
2022-11-21  9:08   ` Heikki Krogerus
2022-11-18 22:45 ` [PATCH 582/606] usb: typec: tcpm/tcpci_rt1711h: " Uwe Kleine-König
2022-11-18 22:57   ` Guenter Roeck
2022-11-21  9:08   ` Heikki Krogerus
2022-11-18 22:45 ` [PATCH 583/606] usb: typec: ucsi/ucsi_ccg: " Uwe Kleine-König
2022-11-21  9:09   ` Heikki Krogerus
2022-11-18 22:45 ` [PATCH 584/606] usb: typec: ucsi: stm32g0: " Uwe Kleine-König
2022-11-21  9:09   ` Heikki Krogerus
2022-11-19  6:50 ` [PATCH 000/606] i2c: Complete conversion to i2c_probe_new patchwork-bot+chrome-platform
2022-11-19  6:50 ` patchwork-bot+chrome-platform
2022-11-19 11:10 ` Wolfram Sang
2022-11-20 19:43 ` Sebastian Reichel
2022-11-21  9:53 ` Lee Jones
2022-11-22 18:58 ` Jonathan Cameron
2022-11-22 20:16   ` Uwe Kleine-König
2022-11-26 15:43     ` Andy Shevchenko
2022-12-09 12:00 ` (subset) " Robert Foss
2022-12-12 16:36 ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3s/rFMTr8JCMuyd@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=ang.iglesiasg@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=uwe@kleine-koenig.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).