From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Jakob Koschel <jakobkoschel@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kevin Cernekee <cernekee@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use
Date: Tue, 22 Nov 2022 17:23:45 +0200 [thread overview]
Message-ID: <Y3zpgRd89Dz/LTPk@smile.fi.intel.com> (raw)
In-Reply-To: <87leoc2pbf.fsf@intel.com>
On Tue, Nov 15, 2022 at 05:46:28PM +0200, Jani Nikula wrote:
> On Mon, 14 Nov 2022, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > Some of the existing users, and definitely will be new ones, want to
> > count existing nodes in the list. Provide a generic API for that by
> > moving code from i915 to list.h.
>
> I think I'd find list_length() a much more natural name for this.
i915 suggests my variant :-)
> *shrug*
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> regardless of what you decide to do with name or static inline etc.
Thanks! I will check which one looks and feels better and update for v3.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-11-22 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 16:22 [PATCH v2 1/4] i915: Move list_count() to list.h for broader use Andy Shevchenko
2022-11-14 16:22 ` [PATCH v2 2/4] usb: gadget: hid: Convert to use list_count() Andy Shevchenko
2022-11-14 19:15 ` Fabio Estevam
2022-11-22 15:20 ` Andy Shevchenko
2022-11-14 16:22 ` [PATCH v2 3/4] usb: gadget: udc: bcm63xx: " Andy Shevchenko
2022-11-14 16:22 ` [PATCH v2 4/4] xhci: " Andy Shevchenko
2022-11-14 18:11 ` [PATCH v2 1/4] i915: Move list_count() to list.h for broader use Ruhl, Michael J
2022-11-14 18:48 ` Andy Shevchenko
2022-11-15 15:46 ` Jani Nikula
2022-11-22 15:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3zpgRd89Dz/LTPk@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cernekee@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jakobkoschel@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).