Re: [usb:usb-testing 2/23] drivers/usb/gadget/function/uvc_v4l2.c:266:3: warning: unannotated fall-through between switch labels

Greg Kroah-Hartman
2022-11-29T12:10:21Z

On Tue, Nov 29, 2022 at 11:19:04AM +0100, Michael Grzeschik wrote:
> On Tue, Nov 29, 2022 at 08:59:04AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Nov 29, 2022 at 08:57:19AM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Nov 29, 2022 at 08:55:43AM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Nov 29, 2022 at 07:22:43AM +0800, kernel test robot wrote:
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > > > > head: 465d4dd073f72a6348577ed0f7aa4aa00c9264bc
> > > > > commit: a6f523ee41bfe7ef71110d4ae556339d0520efdd [2/23] usb: gadget: uvc: add validate and fix function for uvc response
> > > >
> > > > Michael, I'll drop this commit from my tree now, please fix up and
> > > > resend.
> > >
> > > Nevermind, I fixed it up myself, it was trivial.
> >
> > And now ignore this, I've dropped it again based on Laurent's review.
> >
>
> Did you drop it because of the question why this is a good idea?

Yes.

> If so I will improve the commit message. IMHO it totally makes sense to
> have some sort of validation in the uvc gadget.
>
> The version v7 he commented on was not the one you took on the
> usb-testing tree.

Ok, submit a new one so that everyone can agree please.

thanks,

greg k-h