Re: [usb:usb-testing 2/23] drivers/usb/gadget/function/uvc_v4l2.c:266:3: warning: unannotated fall-through between switch labels

Michael Grzeschik
2022-11-29T10:19:19Z

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Tue, Nov 29, 2022 at 08:59:04AM +0100, Greg Kroah-Hartman wrote:
>On Tue, Nov 29, 2022 at 08:57:19AM +0100, Greg Kroah-Hartman wrote:
>> On Tue, Nov 29, 2022 at 08:55:43AM +0100, Greg Kroah-Hartman wrote:
>> > On Tue, Nov 29, 2022 at 07:22:43AM +0800, kernel test robot wrote:
>> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
>> > > head: 465d4dd073f72a6348577ed0f7aa4aa00c9264bc
>> > > commit: a6f523ee41bfe7ef71110d4ae556339d0520efdd [2/23] usb: gadget: uvc: add validate and fix function for uvc response
>> >
>> > Michael, I'll drop this commit from my tree now, please fix up and
>> > resend.
>>
>> Nevermind, I fixed it up myself, it was trivial.
>
>And now ignore this, I've dropped it again based on Laurent's review.
>

Did you drop it because of the question why this is a good idea?

If so I will improve the commit message. IMHO it totally makes sense to
have some sort of validation in the uvc gadget.

The version v7 he commented on was not the one you took on the
usb-testing tree.

Michael

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]