* [PATCH v2] thunderbolt: Do not report errors if on-board retimers are found
@ 2022-12-23 4:22 Utkarsh Patel
2022-12-27 8:43 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Utkarsh Patel @ 2022-12-23 4:22 UTC (permalink / raw)
To: mika.westerberg, michael.jamet, andreas.noever, YehezkelShB,
linux-kernel, linux-usb
Cc: rajmohan.mani, Utkarsh Patel, stable
tb_retimer_scan() returns error even when on-board retimers are found.
Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned")
Cc: stable@vger.kernel.org
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
---
Changes in V2:
1. Removed extra line between the Fixes tag and signed-off.
2. Added the tag for stable tree.
---
drivers/thunderbolt/retimer.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/thunderbolt/retimer.c b/drivers/thunderbolt/retimer.c
index 81252e31014a..6ebe7a2886ec 100644
--- a/drivers/thunderbolt/retimer.c
+++ b/drivers/thunderbolt/retimer.c
@@ -471,10 +471,9 @@ int tb_retimer_scan(struct tb_port *port, bool add)
break;
}
- if (!last_idx) {
- ret = 0;
+ ret = 0;
+ if (!last_idx)
goto out;
- }
/* Add on-board retimers if they do not exist already */
for (i = 1; i <= last_idx; i++) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] thunderbolt: Do not report errors if on-board retimers are found
2022-12-23 4:22 [PATCH v2] thunderbolt: Do not report errors if on-board retimers are found Utkarsh Patel
@ 2022-12-27 8:43 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2022-12-27 8:43 UTC (permalink / raw)
To: Utkarsh Patel
Cc: michael.jamet, andreas.noever, YehezkelShB, linux-kernel,
linux-usb, rajmohan.mani, stable
On Thu, Dec 22, 2022 at 08:22:46PM -0800, Utkarsh Patel wrote:
> tb_retimer_scan() returns error even when on-board retimers are found.
>
> Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned")
> Cc: stable@vger.kernel.org
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
Applied now, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-27 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-23 4:22 [PATCH v2] thunderbolt: Do not report errors if on-board retimers are found Utkarsh Patel
2022-12-27 8:43 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).