From: Greg KH <gregkh@linuxfoundation.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Jakub Kicinski <kuba@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit
Date: Thu, 12 Jan 2023 11:00:59 +0100 [thread overview]
Message-ID: <Y7/aW65pyGeebM/6@kroah.com> (raw)
In-Reply-To: <87k01s6tkr.fsf@miraculix.mork.no>
On Thu, Jan 12, 2023 at 09:33:08AM +0100, Bjørn Mork wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> > On Wed, 11 Jan 2023 13:32:28 +0000 Andre Przywara wrote:
> >> The Microsoft Devkit 2023 is a an ARM64 based machine featuring a
> >> Realtek 8153 USB3.0-to-GBit Ethernet adapter. As in their other
> >> machines, Microsoft uses a custom USB device ID.
> >>
> >> Add the respective ID values to the driver. This makes Ethernet work on
> >> the MS Devkit device. The chip has been visually confirmed to be a
> >> RTL8153.
> >
> > Hm, we have a patch in net-next which reformats the entries:
> > ec51fbd1b8a2bca2948dede99c14ec63dc57ff6b
> >
> > Would you like this ID to be also added in stable? We could just
> > apply it to net, and deal with the conflict locally. But if you
> > don't care about older kernels then better if you rebase.
>
> And now I started worrying about consequences of that reformatting...
> Maybe I didn't give this enough thought?
Just send a reformatting patch for stable as well. I've taken patches
like that many times for other drivers/subsystems to make backports
trivial.
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-12 10:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:32 [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit Andre Przywara
2023-01-12 5:31 ` Jakub Kicinski
2023-01-12 8:33 ` Bjørn Mork
2023-01-12 10:00 ` Greg KH [this message]
2023-01-12 10:01 ` [PATCH net-next] r8152; preserve device list format Bjørn Mork
2023-01-12 10:12 ` Greg KH
2023-01-12 10:18 ` Bjørn Mork
2023-01-12 10:21 ` Greg KH
2023-01-12 10:29 ` Bjørn Mork
2023-01-12 10:36 ` Greg KH
2023-01-13 10:16 ` Bjørn Mork
2023-01-13 19:54 ` Jakub Kicinski
2023-01-12 10:51 ` [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit Andre Przywara
2023-01-12 11:39 ` Paolo Abeni
2023-01-12 11:56 ` Andre Przywara
2023-01-12 13:08 ` Paolo Abeni
2023-01-12 13:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7/aW65pyGeebM/6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andre.przywara@arm.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).