From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B419AC3DA7A for ; Thu, 5 Jan 2023 14:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232911AbjAEOJa (ORCPT ); Thu, 5 Jan 2023 09:09:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjAEOJ2 (ORCPT ); Thu, 5 Jan 2023 09:09:28 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C14E230562 for ; Thu, 5 Jan 2023 06:09:26 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id a184so14608008pfa.9 for ; Thu, 05 Jan 2023 06:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Wv/1ROf5cSrE4etzGJnivLM/9LV4+ygjSdn9zcWL5jQ=; b=F09Ao6g+F78kfQhfq55+y0MnCQvp23n+R1EA14g8mQn1PeY9Pl3nCB6ighGTaBhfni SGss9jdW018YtAZ8/rFaNV6eY3RGrukiPouEFl4WwObBrkxCzAbo2Z6XF+N+VZJuBhKG IkmxoNwBBLSHe4yj6PuLXnRBtLzKljLoEHAwR6EMyW4+WZAiYC6NTZb7o4MB7Guz+3I2 L2BB1zqMSc74+LN9W0spGbxOO86XTTp+I/TfFmIYf6/8W3Tuz115R2LdL1cKGCTSm9+j Hkzyc9r77kB3YQGy4otND+WsnsEcYZW6WIilvhY0DsYzaoeI5S2DAb6hqi/6JTHTx1A+ iS5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wv/1ROf5cSrE4etzGJnivLM/9LV4+ygjSdn9zcWL5jQ=; b=QcbNzAHI8O+x9Bd5etVGqRXgEHLPhREWlfMmyc1/W4tx5M/yoqd+llNJGEGDDfykui dEANBQF0+Z39QYKsVM64MrgRSlOEO6QK3Cw0G8ICUfA07eRSWHK7FT921cmzPlLNzuX7 YaREr31mF1IJtg9S1gDjg8l1QkNfKq+QAPbhee+9CzFe21Ey+LOOSKPP0NXPEjyGsJZc HrR7UbrCFzu7fZh0fzDrMlSjHANwYSYM9u1NLi32xCilcZQ60LIHZqiPQ39Y95CcO7RE NNS/fMzqA01z79346Df7Uk4pNvA0PhTF+gXSOPHQf1RXDD/ZWZh7jiKbk9nrjS7yAJjb qftw== X-Gm-Message-State: AFqh2krsHtLXL1Z1nYzkEwbpKmbTjLG4t+S0Pm2zUzOviqxVoXwAW9Ps eN7BWqOkyVWkXvEoSlqyWpljuQ== X-Google-Smtp-Source: AMrXdXt44eZzwDUbweK5bwtXX/tYZo3oP/1fuvfvH8E9dN7ppDoFy1IhqIdGTL0WMSDPHTv1v8KeRA== X-Received: by 2002:a62:6145:0:b0:581:7cb0:1eb8 with SMTP id v66-20020a626145000000b005817cb01eb8mr30936406pfb.17.1672927766129; Thu, 05 Jan 2023 06:09:26 -0800 (PST) Received: from localhost (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id h1-20020a628301000000b0056be4dbd4besm9907881pfe.111.2023.01.05.06.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 06:09:25 -0800 (PST) Date: Thu, 5 Jan 2023 15:09:22 +0100 From: Jiri Pirko To: Hui Wang Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, davem@davemloft.net, oliver@neukum.org, kuba@kernel.org Subject: Re: [PATCH] net: usb: cdc_ether: add support for Thales Cinterion PLS62-W modem Message-ID: References: <20230105034249.10433-1-hui.wang@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105034249.10433-1-hui.wang@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Thu, Jan 05, 2023 at 04:42:49AM CET, hui.wang@canonical.com wrote: >This modem has 7 interfaces, 5 of them are serial interfaces and are >driven by cdc_acm, while 2 of them are wwan interfaces and are driven >by cdc_ether: >If 0: Abstract (modem) >If 1: Abstract (modem) >If 2: Abstract (modem) >If 3: Abstract (modem) >If 4: Abstract (modem) >If 5: Ethernet Networking >If 6: Ethernet Networking > >Without this change, the 2 network interfaces will be named to usb0 >and usb1, our QA think the names are confusing and filed a bug on it. > >After applying this change, the name will be wwan0 and wwan1, and >they could work well with modem manager. > >Signed-off-by: Hui Wang Reviewed-by: Jiri Pirko