From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C297C54EBD for ; Mon, 9 Jan 2023 15:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbjAIPtL (ORCPT ); Mon, 9 Jan 2023 10:49:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237332AbjAIPsj (ORCPT ); Mon, 9 Jan 2023 10:48:39 -0500 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 3D241108E for ; Mon, 9 Jan 2023 07:48:35 -0800 (PST) Received: (qmail 638441 invoked by uid 1000); 9 Jan 2023 10:48:34 -0500 Date: Mon, 9 Jan 2023 10:48:34 -0500 From: Alan Stern To: Juhyung Park Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, gregkh@linuxfoundation.org, zenghongling@kylinos.cn, zhongling0719@126.com Subject: Re: [PATCH] Revert "usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS" Message-ID: References: <20230109115550.71688-1-qkrwngud825@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109115550.71688-1-qkrwngud825@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jan 09, 2023 at 08:55:50PM +0900, Juhyung Park wrote: > This reverts commit e00b488e813f0f1ad9f778e771b7cd2fe2877023. > > The commit e00b488e813f ("usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS") > blacklists UAS for the entire RTL9210 enclosures. Realtek's VendorId is 0x0bda > and RTL9210 enclosures reports 0x9210 for its ProductId. > > The RTL9210 controller was advertised with UAS since its release back in 2019 > and was shipped with a lot of enclosure products with different firmware > combinations. > > If UAS blacklisting is really required said product (Hiksemi USB3-FW), it > should be done without blacklisting the entire RTL9210 products. We cannot simply revert a patch if it fixes a problem for some devices. The devices would then stop working and that would be a regression, which is not allowed. It will be necessary to find some other way of solving this problem. For example, a small piece of test code which can safely determine whether the firmware can handle UAS. Alan Stern > Fixes: e00b488e813f ("usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS") > Cc: Alan Stern > Cc: Hongling Zeng > Signed-off-by: Juhyung Park > --- > drivers/usb/storage/unusual_uas.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index 251778d14e2d..c7b763d6d102 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -83,13 +83,6 @@ UNUSUAL_DEV(0x0bc2, 0x331a, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_REPORT_LUNS), > > -/* Reported-by: Hongling Zeng */ > -UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999, > - "Hiksemi", > - "External HDD", > - USB_SC_DEVICE, USB_PR_DEVICE, NULL, > - US_FL_IGNORE_UAS), > - > /* Reported-by: Benjamin Tissoires */ > UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, > "Initio Corporation", > -- > 2.39.0 >