From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20099C54EED for ; Mon, 30 Jan 2023 16:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237449AbjA3Qhw (ORCPT ); Mon, 30 Jan 2023 11:37:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235634AbjA3Qhv (ORCPT ); Mon, 30 Jan 2023 11:37:51 -0500 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 6A44B3B0D0 for ; Mon, 30 Jan 2023 08:37:49 -0800 (PST) Received: (qmail 414002 invoked by uid 1000); 30 Jan 2023 11:37:48 -0500 Date: Mon, 30 Jan 2023 11:37:48 -0500 From: Alan Stern To: Daniel Scally Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, laurent.pinchart@ideasonboard.com, mgr@pengutronix.de, balbi@kernel.org, kieran.bingham@ideasonboard.com, torleiv@huddly.com Subject: Re: [PATCH v3 06/11] usb: gadget: configfs: Support arbitrary string descriptors Message-ID: References: <20230130093443.25644-1-dan.scally@ideasonboard.com> <20230130093443.25644-7-dan.scally@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130093443.25644-7-dan.scally@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jan 30, 2023 at 09:34:38AM +0000, Daniel Scally wrote: > Add a framework to allow users to define arbitrary string descriptors > for a USB Gadget. This is modelled as a new type of config item rather > than as hardcoded attributes so as to be as flexible as possible. > > Signed-off-by: Daniel Scally > --- > Changes in v3: > > - Moved this functionality from the UVC function to usb gadget core. > > Changes in v2: > > - New patch > > drivers/usb/gadget/configfs.c | 172 +++++++++++++++++++++++++++++++++- > include/linux/usb/gadget.h | 11 +++ > 2 files changed, 181 insertions(+), 2 deletions(-) Shouldn't this patch also include an update to Documentation/usb/gadget_configfs.rst? Alan Stern